From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1585 invoked by alias); 19 Dec 2012 14:23:55 -0000 Received: (qmail 1575 invoked by uid 22791); 19 Dec 2012 14:23:54 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Dec 2012 14:23:45 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBJENhw0011121 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Dec 2012 09:23:43 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qBJENgvY025528 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 19 Dec 2012 09:23:43 -0500 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 2/2] Move registering maint cmd from maint.c to symmisc.c. References: <1355903736-25543-1-git-send-email-yao@codesourcery.com> <1355903736-25543-2-git-send-email-yao@codesourcery.com> Date: Wed, 19 Dec 2012 14:23:00 -0000 In-Reply-To: <1355903736-25543-2-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Wed, 19 Dec 2012 15:55:36 +0800") Message-ID: <87k3sep1ch.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00701.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2012-12-19 Yao Qi Yao> * maint.c (_initialize_maint_cmds): Move code ... Yao> * symmisc.c (_initialize_symmisc): ... to here. Yao> (maintenance_print_msymbols): Make it static. Yao> (maintenance_print_objfiles): Likewise. Yao> (maintenance_print_symbols): Likewise. Yao> (maintenance_info_symtabs): Likewise. Yao> * symtab.h (maintenance_print_msymbols): Remove declaration. Yao> (maintenance_print_objfiles, maintenance_print_symbols): Likewise. Yao> (maintenance_info_symtabs): Likewise. Ok. I forgot to mention, the previous patch is ok. You can make the initialize_file_ftype change if you want. I don't think it matters very much either way. Tom