From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7557 invoked by alias); 7 Feb 2013 20:58:06 -0000 Received: (qmail 7546 invoked by uid 22791); 7 Feb 2013 20:58:05 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_MD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Feb 2013 20:57:57 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r17KvtUc021956 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Feb 2013 15:57:55 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r17Kvsrf021059 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 7 Feb 2013 15:57:55 -0500 From: Tom Tromey To: Doug Evans Cc: gdb-patches Subject: Re: FYI: fix error in py-type.c References: <877gmlxu1l.fsf@fleche.redhat.com> <87pq0dw1b1.fsf@fleche.redhat.com> Date: Thu, 07 Feb 2013 20:58:00 -0000 In-Reply-To: (Doug Evans's message of "Thu, 7 Feb 2013 11:22:30 -0800") Message-ID: <87k3qjvo31.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00195.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> I think the bar for contrib is in general lower. Doug> I think you should feel free to add the FIXMEs you deem appropriate Doug> and check it in. Doug> [... and maybe leverage the net to fix them for you :-)] I'll send the series in a minute. What I did is add some options to the summarizer script. The default is to disable reporting for the checks that are generally not useful. I checked the indirect function call errors and for the most part they aren't important. After the series I still get the appended. This is a bug, but pretty obscure. Tom ../../archer/gdb/python/py-cmd.c:404: error: function cmdpy_init is marked nothrow but can throw ../../archer/gdb/python/py-cmd.c:451: info: via call to gdbpy_parse_command_name ../../archer/gdb/python/py-cmd.c:359: info: via call to lookup_cmd_1 ../../archer/gdb/cli/cli-decode.c:1381: info: via call to deprecated_cmd_warning ../../archer/gdb/cli/cli-decode.c:1587: info: via call to printf_filtered ../../archer/gdb/utils.c:2437: info: via call to vfprintf_filtered ../../archer/gdb/utils.c:2348: info: via call to vfprintf_maybe_filtered ../../archer/gdb/utils.c:2340: info: via call to fputs_maybe_filtered ../../archer/gdb/utils.c:2112: info: via call to prompt_for_continue ../../archer/gdb/utils.c:1902: info: via call to quit ../../archer/gdb/utils.c:1142: info: via call to fatal ../../archer/gdb/utils.c:740: info: via call to throw_vfatal ../../archer/gdb/python/py-param.c:655: error: function parmpy_init is marked nothrow but can throw ../../archer/gdb/python/py-param.c:709: info: via call to gdbpy_parse_command_name ../../archer/gdb/python/py-cmd.c:359: info: via call to lookup_cmd_1 ../../archer/gdb/cli/cli-decode.c:1381: info: via call to deprecated_cmd_warning ../../archer/gdb/cli/cli-decode.c:1587: info: via call to printf_filtered ../../archer/gdb/utils.c:2437: info: via call to vfprintf_filtered ../../archer/gdb/utils.c:2348: info: via call to vfprintf_maybe_filtered ../../archer/gdb/utils.c:2340: info: via call to fputs_maybe_filtered ../../archer/gdb/utils.c:2112: info: via call to prompt_for_continue ../../archer/gdb/utils.c:1902: info: via call to quit ../../archer/gdb/utils.c:1142: info: via call to fatal ../../archer/gdb/utils.c:740: info: via call to throw_vfatal