From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99465-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15519 invoked by alias); 12 Mar 2013 18:49:00 -0000
Received: (qmail 15510 invoked by uid 22791); 12 Mar 2013 18:49:00 -0000
X-SWARE-Spam-Status: No, hits=-7.7 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 18:48:53 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2CImpn3012267	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 12 Mar 2013 14:48:52 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2CImopO018361	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 12 Mar 2013 14:48:51 -0400
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 02/15] Save trace into CTF format
References: <1362800844-27940-1-git-send-email-yao@codesourcery.com>	<1362800844-27940-3-git-send-email-yao@codesourcery.com>
Date: Tue, 12 Mar 2013 18:49:00 -0000
In-Reply-To: <1362800844-27940-3-git-send-email-yao@codesourcery.com> (Yao	Qi's message of "Sat, 9 Mar 2013 11:47:11 +0800")
Message-ID: <87k3pcfo8d.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00541.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> This patch is to teach GDB to save trace data into CTF format.  In
Yao> this patch, struct trace_frame_write_ops and struct
Yao> trace_file_write_ops are implemented, so that GDB is able to write
Yao> trace data in CTF format.

Yao> +  struct cleanup *cleanup;

The cleanup issue, as with patch 01, is the only issue I found.
The rest looks good.

Tom