From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26871 invoked by alias); 27 Jun 2013 20:12:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26854 invoked by uid 89); 27 Jun 2013 20:12:11 -0000 X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 27 Jun 2013 20:12:11 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5RKC9p0012047 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Jun 2013 16:12:09 -0400 Received: from barimba (ovpn-113-102.phx2.redhat.com [10.3.113.102]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5RKC8bp017479 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 27 Jun 2013 16:12:09 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 08/16] push last_program_signals_packet into struct remote_state References: <1371835506-15691-1-git-send-email-tromey@redhat.com> <1371835506-15691-9-git-send-email-tromey@redhat.com> <51C88303.10006@redhat.com> Date: Thu, 27 Jun 2013 20:13:00 -0000 In-Reply-To: <51C88303.10006@redhat.com> (Pedro Alves's message of "Mon, 24 Jun 2013 18:33:55 +0100") Message-ID: <87k3lfmhyg.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-06/txt/msg00858.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> + /* The last QProgramSignals packet sent to the target. We bypass >> + sending a new program signals list down to the target if the new >> + packet is exactly the same as the last we sent. IOW, we only let >> + the target know about program signals list changes. */ >> + >> + char *last_program_signals_packet; Pedro> I noticed a couple of the patches add an empty line between comment Pedro> and variable, while the rest of the structure doesn't do that. Thanks. I fixed all the instances of this. Tom