From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5304 invoked by alias); 22 Nov 2013 17:56:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5293 invoked by uid 89); 22 Nov 2013 17:56:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2013 17:56:57 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAMHuoOY023718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 22 Nov 2013 12:56:50 -0500 Received: from barimba (ovpn-113-124.phx2.redhat.com [10.3.113.124]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAMHunHJ017073 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 22 Nov 2013 12:56:49 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] handle an unspecified return address column References: <1384375873-32160-1-git-send-email-tromey@redhat.com> <1384375873-32160-3-git-send-email-tromey@redhat.com> Date: Fri, 22 Nov 2013 18:22:00 -0000 In-Reply-To: <1384375873-32160-3-git-send-email-tromey@redhat.com> (Tom Tromey's message of "Wed, 13 Nov 2013 13:51:13 -0700") Message-ID: <87k3g0cobj.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00694.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> Debugging PR 16155 further, I found that the DWARF unwinder found the Tom> function in question, but thought it had no registers saved Tom> (fs->regs.num_regs == 0). Tom> It seems to me that if a frame does not specify the return address Tom> column, or if the return address column is explicitly marked as Tom> DWARF2_FRAME_REG_UNSPECIFIED, then we should set the Tom> "undefined_retaddr" flag and let the DWARF unwinder gracefully stop. Tom> This patch implements that idea. I'm going to check this in shortly. Tom