Re: [PATCH v4 9/9] enable target-async

Tom Tromey
2014-02-24T17:38:01Z

Pedro> Sorry, I wasn't clear. I understand what as a whole the patch is trying
Pedro> to do; what I don't understand is why a hack was necessary, or its
Pedro> implementation. E.g., what exactly fails if the hack is not
Pedro> in place?; Why this spot for the hack?; What's the predicate used in
Pedro> the hack actually checking?

Tom> I don't remember, but I'll back it out and redo the analysis to find
Tom> out.

Pedro> Now that I looked again a little closer, I recalled that GDB in
Pedro> sync mode always outputs a silly extra prompt right after
Pedro> ^running (in response to execution commands), before the target
Pedro> stops, even though GDB is not ready for input then. Guess this
Pedro> hack is related?

Tom> Probably so.

Yes, this is what is going on. If I remove the prompt-printing code
here, then a simple case like mi-start.exp fails because gdb fails to
print a prompt after the *stopped notification.

Moving the prompt printing elsewhere doesn't really help, either,
because other choices mean introducing test regressions somewhere.

Tom