From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22839 invoked by alias); 8 Jul 2014 01:53:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22678 invoked by uid 89); 8 Jul 2014 01:52:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f45.google.com Received: from mail-qg0-f45.google.com (HELO mail-qg0-f45.google.com) (209.85.192.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 08 Jul 2014 01:52:53 +0000 Received: by mail-qg0-f45.google.com with SMTP id a108so4444231qge.18 for ; Mon, 07 Jul 2014 18:52:51 -0700 (PDT) X-Received: by 10.140.93.163 with SMTP id d32mr52932263qge.1.1404784371120; Mon, 07 Jul 2014 18:52:51 -0700 (PDT) Received: from hydrogen (naesten-pt.tunnel.tserv4.nyc4.ipv6.he.net. [2001:470:1f06:57::2]) by mx.google.com with ESMTPSA id g18sm72815356qaa.33.2014.07.07.18.52.49 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 07 Jul 2014 18:52:50 -0700 (PDT) Received: from naesten by hydrogen with local (Exim 4.82) (envelope-from ) id 1X4KaO-0000S7-CV; Mon, 07 Jul 2014 21:52:48 -0400 From: Samuel Bronson To: Cc: "'gdb-patches\@sourceware.org'" Subject: Re: [PATCH] Fix gdb.base/code_elim.exp failures for PowerPC 32-bit References: <53B28365.1010508@codesourcery.com> Date: Tue, 08 Jul 2014 01:53:00 -0000 In-Reply-To: <53B28365.1010508@codesourcery.com> (Luis Machado's message of "Tue, 1 Jul 2014 11:46:13 +0200") Message-ID: <87k37ok45r.fsf@naesten.mooo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00139.txt.bz2 Luis Machado writes: > For PowerPC 32-bit though, the small initialized global int variable > is sent to the .sdata section as an optimization. Since there is no > more data to store, the .data section doesn't get created. > > GDB complains about the lack of such a section and expect doesn't like > seeing that warning, which results in a couple failures for powerpc. Hmm, seems like a silly thing to complain about ... > One of them: > > [snip] > add-symbol-file gdb.base/code_elim2 0x200000 -s .data 0x210000 -s .bss 0x220000^M > add symbol table from file "gdb.d/gdb.base/code_elim2" at^M > .text_addr = 0x200000^M > .data_addr = 0x210000^M > .bss_addr = 0x220000^M > (y or n) y^M > Reading symbols from gdb.base/code_elim2...warning: section .data not > found in gdb.base/code_elim2^M > done.^M > (gdb) FAIL: gdb.base/code_elim.exp: order1: add-symbol-file code_elim2 > 0x200000 > > I have tweaked the testcase sources a little to hold a bigger > initialized global variable, forcing the linker to create a regular > .data section in order to prevent GDB's warning. The testcase still > runs fine, but now PowerPC 32-bit sees full passes on this one. Is tweaking the testcase really the best approach here? Shouldn't GDB just be less picky?