From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30677 invoked by alias); 11 Jul 2014 15:35:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30610 invoked by uid 89); 11 Jul 2014 15:35:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 11 Jul 2014 15:35:32 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6BFZTFj022672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 11 Jul 2014 11:35:30 -0400 Received: from barimba (ovpn-113-95.phx2.redhat.com [10.3.113.95]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6BFZSxx025803 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Fri, 11 Jul 2014 11:35:28 -0400 From: Tom Tromey To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 07/15] Remove GDBSERVER use from nat/i386-dregs.c References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-8-git-send-email-gbenson@redhat.com> <87k37ldrz4.fsf@fleche.redhat.com> <20140711125306.GC2695@blade.nx> Date: Fri, 11 Jul 2014 15:38:00 -0000 In-Reply-To: <20140711125306.GC2695@blade.nx> (Gary Benson's message of "Fri, 11 Jul 2014 13:53:06 +0100") Message-ID: <87k37j7vsw.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-07/txt/msg00277.txt.bz2 >>>>> "Gary" == Gary Benson writes: Gary> -#ifdef GDBSERVER Gary> -#include "server.h" Gary> -#else Gary> -#include "defs.h" Gary> -#include "inferior.h" Gary> -#endif Gary> +#include "common-utils.h" >> I think this should include config.h first. Gary> common-utils.h includes it. Or did you mean the gnulib one? Nope, not the gnulib one. I didn't realize that common-utils.h includes config.h. That seems weird to me. I think it's generally better for "random" headers not to include config.h and to either have a "standard" base header (like defs.h or server.h) that includes config.h, or to just have explicit includes of config.h as the first thing in each .c. I realize it's not a problem arising from your series. But would you mind just having the .c include config.h explicitly? Then at some point I'll go through and fix up common-utils.h and its users. Tom