From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24355 invoked by alias); 12 Jul 2014 12:37:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24326 invoked by uid 89); 12 Jul 2014 12:37:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: hera.aquilenet.fr Received: from hera.aquilenet.fr (HELO hera.aquilenet.fr) (141.255.128.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Jul 2014 12:36:58 +0000 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 23FAF3355; Sat, 12 Jul 2014 14:36:55 +0200 (CEST) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a3P0KWlnhbHB; Sat, 12 Jul 2014 14:36:55 +0200 (CEST) Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by hera.aquilenet.fr (Postfix) with ESMTPSA id BE91F31E5; Sat, 12 Jul 2014 14:36:54 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] guile: Remove (gdb init) module, and include 'init.scm'. References: <87tx7fl1ch.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 Messidor an 222 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Sat, 12 Jul 2014 14:55:00 -0000 In-Reply-To: (Doug Evans's message of "Fri, 11 Jul 2014 21:38:07 -0700") Message-ID: <87k37ikb2x.fsf@gnu.org> User-Agent: Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-07/txt/msg00302.txt.bz2 Hi, Doug, Doug Evans skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> This patch is a prerequisite for the following (compiling Scheme >> files). It removes the (gdb init), which had a top-level circular >> dependency with (gdb), thereby preventing compilation. >> >> Thanks, >> Ludo=E2=80=99. >> >> gdb/ >> 2014-06-20 Ludovic Court=C3=A8s >> >> * guile/guile.c: (gdbscm_init_module_name): Change to "gdb". >> * guile/lib/gdb.scm: Remove 'use-modules' form and include >> gdb/init.scm. Change 're-export' to 'export'. Export >> '*pretty-printers*' and '%assert-type'. >> * guile/lib/gdb/init.scm: Remove 'define-module' form. >> (%exception-print-style): Remove. >> * guile/lib/gdb/boot.scm: Change (gdb init) to (gdb). >> * guile/lib/gdb/experimental.scm: Remove use of (gdb init). >> * guile/lib/gdb/types.scm: Likewise. >> * guile/lib/gdb/printing.scm: Add '%assert-type', 'SCM_ARG1', and >> '*pretty-printers*' to the selection. > > Hi. > > IWBN to not export %assert-type. > I was also thinking IWBN to not export *pretty-printers* and instead > export a function that returns the value. WDYT? I agree, but that was needed for gdb/printing.scm. That said, we may be able to access them from there using =E2=80=98@@=E2=80= =99. Perhaps that=E2=80=99d be preferable. I can try that if you want. WDYT? > btw, is (include ...) documented anywhere? Yes (info "(guile) Local Inclusion"). Thanks, Ludo=E2=80=99.