From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9548 invoked by alias); 8 Aug 2014 14:10:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9539 invoked by uid 89); 8 Aug 2014 14:10:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 08 Aug 2014 14:10:13 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s78EA9IW015710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Aug 2014 10:10:09 -0400 Received: from barimba (ovpn-113-151.phx2.redhat.com [10.3.113.151]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s78EA6XE008783 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Fri, 8 Aug 2014 10:10:08 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH] Remove duplicated code on checking address 0x0 is accessiable References: <1407496273-29483-1-git-send-email-yao@codesourcery.com> Date: Fri, 08 Aug 2014 14:10:00 -0000 In-Reply-To: <1407496273-29483-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Fri, 8 Aug 2014 19:11:13 +0800") Message-ID: <87k36jdqdd.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-08/txt/msg00168.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2014-08-08 Yao Qi Yao> * gdb.base/display.exp: Invoke is_address_zero_readable. Yao> * gdb.guile/scm-value.exp (test_value_in_inferior): Likewise. Yao> * gdb.python/py-value.exp (test_value_in_inferior): Likewise. Yao> * gdb.base/hbreak-unmapped.exp: Return if Yao> is_address_zero_readable returns true. Yao> * gdb.base/signest.exp: Likewise. Yao> * gdb.base/signull.exp: Likewise. Yao> * gdb.base/sigbpt.exp: Likewise. Yao> * gdb.guile/scm-disasm.exp: Do the test if Yao> is_address_zero_readable returns false. Yao> * gdb.guile/scm-pretty-print.exp (run_lang_tests): Likewise. Yao> * gdb.python/py-arch.exp: Likewise. Yao> * gdb.python/py-prettyprint.exp (run_lang_tests): Likewise. Yao> * lib/gdb.exp (is_address_zero_readable): New proc. Nice cleanup. This is ok. Tom