From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9630 invoked by alias); 21 Oct 2014 13:07:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9596 invoked by uid 89); 21 Oct 2014 13:07:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Oct 2014 13:07:47 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1XgZA8-0001oN-N8 from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Tue, 21 Oct 2014 06:07:44 -0700 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.181.6; Tue, 21 Oct 2014 06:07:43 -0700 From: Yao Qi To: CC: "'gdb-patches@sourceware.org'" Subject: Re: [PATCH, v2] Fix ARM machine state testcase failures References: <54464B82.6030703@codesourcery.com> Date: Tue, 21 Oct 2014 13:07:00 -0000 In-Reply-To: <54464B82.6030703@codesourcery.com> (Luis Machado's message of "Tue, 21 Oct 2014 10:03:14 -0200") Message-ID: <87k33tingn.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00548.txt.bz2 Luis Machado writes: > + /* Handle bit P. */ > + if (bit (arm_insn_r->arm_insn, 24)) > + { > + record_buf_mem[1] =3D tgt_mem_addr; > + } > + else > + { > + record_buf_mem[1] =3D (uint32_t) u_regval; > + } These braces are not necessary. --=20 Yao (=E9=BD=90=E5=B0=A7)