From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87097 invoked by alias); 28 Apr 2015 10:04:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87082 invoked by uid 89); 28 Apr 2015 10:04:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_NEUTRAL autolearn=ham version=3.3.2 X-HELO: sasl.smtp.pobox.com Received: from pb-sasl1.int.icgroup.com (HELO sasl.smtp.pobox.com) (208.72.237.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Apr 2015 10:04:22 +0000 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id B3C7540BCD; Tue, 28 Apr 2015 06:04:20 -0400 (EDT) Received: from pb-sasl1.int.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id AD55840BCC; Tue, 28 Apr 2015 06:04:20 -0400 (EDT) Received: from rusty (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id 12F9E40BCB; Tue, 28 Apr 2015 06:04:19 -0400 (EDT) From: Andy Wingo To: Eli Zaretskii Cc: gdb-patches@sourceware.org, dje@google.com Subject: Re: [PATCH v5] Add Guile frame filter interface References: <87zj6hfg6t.fsf@igalia.com> <87pp7dferl.fsf@igalia.com> <83sic9dz6q.fsf@gnu.org> Date: Tue, 28 Apr 2015 10:46:00 -0000 In-Reply-To: <83sic9dz6q.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Apr 2015 19:49:33 +0300") Message-ID: <87k2wwtvq6.fsf@igalia.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: F015C974-ED8D-11E4-B355-CB91CE401EC2-02397024!pb-sasl1.pobox.com X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01029.txt.bz2 Thanks for the feedback, Eli. Updated patch to come will fix nits. One comment: On Thu 09 Apr 2015 18:49, Eli Zaretskii writes: >> From: Andy Wingo >> Cc: dje@google.com >> Date: Thu, 09 Apr 2015 18:27:42 +0200 >> >> +frame @var{dec}. Each item of the list should either be a >> +@value{GDBN} symbol (@pxref{Symbols In Guile}), a pair of a >> +@value{GDBN} symbol and a @value{GDBN} value (@pxref{Values From >> +Inferior In Guile}, or a pair of a string and a @value{GDBN} value. >> +In the first case, the value will be loaded from the frame if needed. > > I'm confused: the first case is when the item is a symbol, so what > value is being alluded to here? I replaced the last sentence with: In the first case, the @value{GDBN} symbol will be used to load the corresponding value from the frame if needed. Andy