From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27121 invoked by alias); 30 Sep 2016 21:40:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27098 invoked by uid 89); 30 Sep 2016 21:40:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Fri, 30 Sep 2016 21:40:26 +0000 Received: (qmail 14230 invoked by uid 0); 30 Sep 2016 21:40:25 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy6.mail.unifiedlayer.com with SMTP; 30 Sep 2016 21:40:25 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id pxgL1t00b2f2jeq01xgPdT; Fri, 30 Sep 2016 15:40:23 -0600 X-Authority-Analysis: v=2.1 cv=IYcUBwaa c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=GW1xBdLrtEIA:10 a=V82Az2P4AAAA:8 a=joi06a1pXwQSrkrJdxEA:9 a=GUYa6fla-me-Zpd7-Uj-:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:51642 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bq5Xa-0006iw-7p; Fri, 30 Sep 2016 15:40:22 -0600 From: Tom Tromey To: Trevor Saunders Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 07/22] Change scoped_minimal_symbol_reader to store objfile References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-8-git-send-email-tom@tromey.com> <20160929090743.4i44bg6egfflvkbe@ball> Date: Fri, 30 Sep 2016 21:41:00 -0000 In-Reply-To: <20160929090743.4i44bg6egfflvkbe@ball> (Trevor Saunders's message of "Thu, 29 Sep 2016 05:07:43 -0400") Message-ID: <87k2dt9id7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bq5Xa-0006iw-7p X-Source-Sender: 71-218-192-86.hlrn.qwest.net (pokyo) [71.218.192.86]:51642 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-09/txt/msg00442.txt.bz2 >>>>> "Trevor" == Trevor Saunders writes: >> Currently, minimal symbol table creation is not reentrant; it >> relies on global (static) variables in minsyms.c. */ >> >> - explicit scoped_minimal_symbol_reader (); >> + explicit scoped_minimal_symbol_reader (struct objfile *); Trevor> C++ doesn't require the explicit struct / union when refering to the Trevor> type, though of course you can keep them if you think it makes something Trevor> clearer. I kept it just because "struct objfile" is used everywhere else in gdb. >> @@ -79,6 +79,8 @@ class scoped_minimal_symbol_reader >> scoped_minimal_symbol_reader &operator= >> (const scoped_minimal_symbol_reader &); >> scoped_minimal_symbol_reader (const scoped_minimal_symbol_reader &); >> + >> + struct objfile *objfile; Trevor> fwiw gcc convention is to prefix members with m_, so doing so in gdb as Trevor> well would be nice. I made this change. Tom