From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26501 invoked by alias); 20 Jun 2017 13:00:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26176 invoked by uid 89); 20 Jun 2017 13:00:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=BAYES_00,SPF_HELO_PASS,TRACKER_ID,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:990 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 13:00:36 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 09D9B4ACCB; Tue, 20 Jun 2017 13:00:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 09D9B4ACCB Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 09D9B4ACCB Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D39776DAC2; Tue, 20 Jun 2017 13:00:34 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: GDB Patches , Pedro Alves Subject: Re: [PATCH v8] C++ify gdb/common/environ.c References: <20170413040455.23996-1-sergiodj@redhat.com> <20170620032740.30497-1-sergiodj@redhat.com> Date: Tue, 20 Jun 2017 13:00:00 -0000 In-Reply-To: (Simon Marchi's message of "Tue, 20 Jun 2017 14:46:48 +0200") Message-ID: <87k246vmod.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00570.txt.bz2 On Tuesday, June 20 2017, Simon Marchi wrote: > On 2017-06-20 05:27, Sergio Durigan Junior wrote: >> +/* Create a gdb_environ object using the host's environment >> + variables. */ > > This comment (about from_host_environ) should probably go in the > header file, with a /* See common/environ.h. */ here. Fixed. >> + /* Return the value in the environment for the variable VAR. The >> + return pointer is only valid as long as VAR is not > > return -> returned? Fixed. >> + removed/replaced from the environment. */ > > What if another variable is set and it causes reallocation of the > vector? We could be safe and say "as long as the gdb_environ object > is not modified". Fixed. > Otherwise, LGTM. Thanks to both of you for the valuable comments. Pushed. 9a6c7d9c021cfeb290d76584db7a01e57e7c3d4e -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/