RE: [PATCH] Import setenv and unsetenv from gnulib

Anton Kolesov
2017-07-05T09:50:55Z

> >>
> >> Did you run regression test on x86-linux? If there is no regression,
> >> patches is good to me.
> >
> > If I run "make check-gdb", I don't see any obvious new errors from this
> patch.
> > Unfortunately results are a little bit volatile - some tests
> > sporadically fail even if I run them with same GDB build and sources,
> > even without this patch - I've run testsuite five times and got five similar,
> but different results.
>
> Yeah, our testsuite has racy fails which are well known. What are the tests
> that fail sporadically?

- gdb.base/checkpoint-ns.exp: break
- gdb.base/checkpoint.exp: break2 with many checkpoints
- gdb.btrace/exception.exp: indented
- Several consequtive tests in gdb.btrace/rn-dl-bind.exp
- gdb.threads/process-dies-while-handling-bp.exp: non_stop=off (KFAIL became
PASS with my patch).

Anton

>
> --
> Sergio
> GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send
> encrypted e-mail if possible
> https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__sergiodj.net_&d=DwIBAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=bGeZp_Q7
> bzMjryuhhu0vBa43pSPPzpiFmLmHs_6WFqE&m=aD1DqJ1hQsS0rfAg_7NQt6
> UjAXyTJB0Cb1_rsKqMQK0&s=3JcsKwbMsJt-
> bA9MdRr4tPp7azeC0hVKiqr3B8FOTjg&e=