From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22200 invoked by alias); 26 Sep 2017 05:10:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22188 invoked by uid 89); 26 Sep 2017 05:10:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Sep 2017 05:10:52 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EA9A7356F6; Tue, 26 Sep 2017 05:10:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EA9A7356F6 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C24B87AA66; Tue, 26 Sep 2017 05:10:50 +0000 (UTC) From: Sergio Durigan Junior To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/5] Remove regcache_xmalloc References: <20170924024608.4346-1-tom@tromey.com> <20170924024608.4346-2-tom@tromey.com> <87h8vqkqrm.fsf@tromey.com> Date: Tue, 26 Sep 2017 05:10:00 -0000 In-Reply-To: <87h8vqkqrm.fsf@tromey.com> (Tom Tromey's message of "Mon, 25 Sep 2017 22:50:05 -0600") Message-ID: <87k20mjb8l.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00784.txt.bz2 On Tuesday, September 26 2017, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> + struct regcache *regcache = new regcache (data.gdbarch, aspace); > > The builder complained about this line. > It had to be 'new struct regcache' instead. > > However, this was change in a subsequent commit, so my try run didn't > catch it. I suppose I will have to start doing try runs for each > individual patch; which is kind of a pain :( Yeah, sorry about that :-(. On a side note, I was talking to mjw the other day about setting up "special try branches" for some people. I still don't know how that would work internally on BuildBot, but it would address this problem of testing several commits. A problem I foresee with this approach is the extra load on the slaves; some of them are already working around the clock to keep up. Anyway, I don't want to hijack the thread, just wanted to say something related to what happened. > Anyway, I'm sorry about this. The only good thing is that you probably > won't hit this problem unless you bisect. Before I get crucified because of the "spam" generated: each breakage e-mail is related to one specific builder. Sometimes a breakage happens only on e.g. ARM, so you'd get e-mails just for this architecture. Anyway, sorry about the number of messages; it's currently not possible to merge all of the reports into one single message, although it may be possible to thread them. Unfortunately I don't have time right now to look into this, but we don't have a lot of breakages anyway... -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/