Re: [PATCH v3] Enable 'set print inferior-events' and improve detach/fork/kill/exit messages

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Monday, March 26 2018, Pedro Alves wrote:

> On 03/26/2018 11:58 AM, Pedro Alves wrote:
>> On 03/09/2018 09:55 PM, Sergio Durigan Junior wrote:
>> 
>>> But if we use 'add_thread_silent' (with the same configuration as
>>> before):
>>>
>>>   (gdb) run
>>>   Starting program: a.out
>>>   [Attaching after process 26807 fork to child process 26807.]
>
> BTW, those two PIDs being the same looks suspicious.  Is that
> another instance of a parent vs child mixup?  Or is that the case
> that is fixed by the patch?

Ah, good catch.  After some time investigating, I found that the problem
occurs because the code is now calling target_pid_to_str twice in the
same statement, but target_pid_to_str actually returns a static string,
which means that this string is overwritten when the second call
happens:

	  fprintf_filtered (gdb_stdlog,
			    _("[Attaching after %s %s to child %s]\n"),
			    target_pid_to_str (parent_ptid),  <-- HERE
			    has_vforked ? "vfork" : "fork",
			    target_pid_to_str (child_ptid));  <-- AND HERE

I fixed this by saving a copy of both strings before calling
fprintf_filtered.

I'll send an updated patch soon.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/