From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36731 invoked by alias); 26 Jun 2018 20:55:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36715 invoked by uid 89); 26 Jun 2018 20:55:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.60.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Jun 2018 20:55:47 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 090BB400C4C10 for ; Tue, 26 Jun 2018 15:55:46 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id XuzwfmHwZBcCXXv02fXjOm; Tue, 26 Jun 2018 15:55:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=O4EhCS+IqYTZLu5V/3ynWZxBeHpmc9PINub9WPNeUdk=; b=ZNA0UY3Tq991g6p/OyLqH2MMbk uAlvEzgX7Luzo//Dk2EZ7GbZG0+Lr7W+FAWCI3u55yxURPVT+hUI22RE0CrD/7qhyGMdew8bqALYy 3uE+zHeM3n6I7Dkkm25sPjMf2; Received: from 75-166-79-120.hlrn.qwest.net ([75.166.79.120]:46814 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fXuzw-001Ji2-GX; Tue, 26 Jun 2018 15:55:36 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 2/2] Support ptype/o in Rust References: <20180623202227.17259-1-tom@tromey.com> <20180623202227.17259-3-tom@tromey.com> <264bed6a37ca5474bfb51565789905bf@polymtl.ca> Date: Tue, 26 Jun 2018 20:55:00 -0000 In-Reply-To: <264bed6a37ca5474bfb51565789905bf@polymtl.ca> (Simon Marchi's message of "Tue, 26 Jun 2018 15:08:27 -0400") Message-ID: <87k1qls1x4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-06/txt/msg00626.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> + // When printing offsets, we rearrange the fields into storage >> + // order. This lets us show holes more clearly. We work using >> + // field indices here because it simplifies calls to >> + // print_offset_data::update below. Simon> Use /**/ comments. Oops, too much project switching. Thanks for pointing this out. I've fixed this. Tom