From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65611 invoked by alias); 3 Jul 2018 13:17:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65598 invoked by uid 89); 3 Jul 2018 13:17:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Marchi, marchi X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.151.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Jul 2018 13:17:54 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 8ACA91B511 for ; Tue, 3 Jul 2018 08:17:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id aLBJfOkgpbXuJaLBcfZAdk; Tue, 03 Jul 2018 08:17:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ibc+zB7GSYT6JNiffNUpZKLV7/ijd/V5H1A8/QGkdz4=; b=yenaz79ESC+R6SswCoFzCFassS Ebbx0Ljl564iCHzrHJQSTfKFRIg2ZtuWl6yla00xUOdsjUWMFVxiiqxSGnvT2pOzIIVgBumWlnjF0 YqwuJjAG9JL80nySuRKiuqi/l; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:47100 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1faLBI-003VOq-UV; Tue, 03 Jul 2018 08:17:21 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [RFA] Make macOS build warning-free References: <20180629165453.22888-1-tom@tromey.com> <87woudofal.fsf@tromey.com> <5f9b4ce1-aa8d-30e3-98f9-f2c36c3869c6@simark.ca> Date: Tue, 03 Jul 2018 13:17:00 -0000 In-Reply-To: <5f9b4ce1-aa8d-30e3-98f9-f2c36c3869c6@simark.ca> (Simon Marchi's message of "Mon, 2 Jul 2018 12:53:09 -0400") Message-ID: <87k1qco3vk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00044.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> _INTL_MAY_RETURN_STRING_ARG thing is a gcc/binutils/gdb addition, on top of the Simon> v0.12.1 version of gettext. So we shouldn't have to deal with upstream gettext Simon> to fix this, since it's just the gcc/binutils/gdb addition that needs to be fixed. It's upstream as well though. Maybe it was upstreamed from gcc to gettext? I don't really know the history there. I'll send a note to the gettext list. Simon> That bit looks good to me, at least to shut up the compiler. But I'm wondering Simon> if we still need that section_offsets structure, or if we could just replace Simon> it with std::vector/gdb:array_view. I think it's a good idea to rewrite section_offsets, but that seems more involved. Also the way that this code is using std::vector and then turning it into a section_offsets* seems incorrect. I think the symfile.c change isn't enough, btw; the -Wno-deprecated-declarations bit is also required. Otherwise there is at least one error (about the use of syscall). But maybe I could disable that one with a #pragma instead - what do you think? Tom