From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77614 invoked by alias); 8 Jul 2018 16:56:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77599 invoked by uid 89); 8 Jul 2018 16:56:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=tend, mess X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.145.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:56:45 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 8CCF35137 for ; Sun, 8 Jul 2018 11:56:44 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cCzMfqh2ybXuJcCzMf0F5t; Sun, 08 Jul 2018 11:56:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JoeOKvmmM14gbK4pce6zbjniKd87RV/RUu06kWVdvC0=; b=SuxDZp1/LDZ0vVhFZyYq1dEc1b tnYqNi4lHRjddwBZ07RcDcNU//ySNPzC0j6/IbBq4dVMtqrVsxvUUv4IaAv7TcXUIzYgdGR6Z/stN SlmvxuHmTRpYXhQ36wu84ou8c; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:43094 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fcCzM-001WY2-Bn; Sun, 08 Jul 2018 11:56:44 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 11/42] Move processing_gcc to stabsread References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-12-tom@tromey.com> <354ad4b7-836b-8d13-6af2-111047624416@simark.ca> Date: Sun, 08 Jul 2018 16:56:00 -0000 In-Reply-To: <354ad4b7-836b-8d13-6af2-111047624416@simark.ca> (Simon Marchi's message of "Sun, 8 Jul 2018 12:45:57 -0400") Message-ID: <87k1q54qes.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00201.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-05-23 12:58 AM, Tom Tromey wrote: >> processing_gcc is also only used by stabsread -- it is set by the >> DWARF reader, but this turns out not to be needed. So, this patch >> moves processing_gcc and removes the assignment from the DWARF reader. Simon> Any idea if the assignment of processing_gcc_compilation in go32-nat.c is Simon> useful? In looks very strange to me to set that in nat code rather than Simon> in symbol-reading code... Simon> Either way, it LGTM, I am fine if you leave it there to stay on the safe side, Simon> since I suppose you couldn't test that change easily. Yeah, I have no idea and didn't want to mess with that. It does seem incorrect to set it there. Here's the email about that change: https://sourceware.org/ml/gdb-patches/2000-q1/msg00710.html Not much to go on, and long enough ago that many other parts of gdb might well have been very different. Anyway I tend to think that this port in particular can mostly be approached with benign neglect. Tom