From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1656 invoked by alias); 9 Jul 2018 23:07:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1640 invoked by uid 89); 9 Jul 2018 23:07:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jul 2018 23:07:06 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 595BE6BDB for ; Mon, 9 Jul 2018 18:07:05 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cfFJfdumwSjJAcfFJfSS8z; Mon, 09 Jul 2018 18:07:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LvKuR0qgEOAET5q30fVAQyXlvw4UEtYuepWBF3WC0Qc=; b=I+TY+CDjdeEfp/1fr2yNSwES2N ICOAhlIXgw9Gwi5XVZrPPeYfebyGjk5qY5jOBD4pcPBXv54TRhoU42QHrCfLtmBvRL7WRc/Umxpaz aQE6c5h+lwIApXsTPOhkIs5CA; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:47046 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fcfFJ-002XoP-1Z; Mon, 09 Jul 2018 18:07:05 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 14/42] Move scan_file_globals declaration to stabsread.h References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-15-tom@tromey.com> <3a592482-4a95-78c9-e81d-e8220895d687@simark.ca> Date: Mon, 09 Jul 2018 23:07:00 -0000 In-Reply-To: <3a592482-4a95-78c9-e81d-e8220895d687@simark.ca> (Simon Marchi's message of "Sun, 8 Jul 2018 12:52:41 -0400") Message-ID: <87k1q4ovon.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00233.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-05-23 12:58 AM, Tom Tromey wrote: >> scan_file_globals is defined in stabsread.c, so move its declaration >> to stabsread.h. Simon> LGTM, though can you move the comment to the .h and add the usual "See..."? I did this. Tom