Re: [RFA] Make macOS build warning-free

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> I think in the meantime I'll just --disable-nls.  Perhaps you wouldn't
>> mind approving the symfile.c change in isolation.

Simon> That bit looks good to me, at least to shut up the compiler.

I forgot about this for a while, but here is the patch I am checking in.

Tom

commit 027a4c30d03e3f434ddfa61e7f026e3b15f83daa
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Jul 13 11:14:57 2018 -0600

    Remove a warning on macOS
    
    This removes a clang warning coming from -Wmissing-braces.
    
    ChangeLog
    2018-07-13  Tom Tromey  <tom@tromey.com>
    
            * symfile.c (set_objfile_default_section_offset): Use extra braces
            around initializer.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7b808eb3a76..66b7c3681e2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-07-13  Tom Tromey  <tom@tromey.com>
+
+	* symfile.c (set_objfile_default_section_offset): Use extra braces
+	around initializer.
+
 2018-07-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
 
 	* s390-tdep.c (s390_displaced_step_fixup): Adjust PC for a
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 48eca5cc0ea..62b38bd6182 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -2088,7 +2088,7 @@ set_objfile_default_section_offset (struct objfile *objf,
 {
   /* Add OFFSET to all sections by default.  */
   std::vector<struct section_offsets> offsets (objf->num_sections,
-					       { offset });
+					       { { offset } });
 
   /* Create sorted lists of all sections in ADDRS as well as all
      sections in OBJF.  */