From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100753 invoked by alias); 31 Jul 2018 15:48:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100652 invoked by uid 89); 31 Jul 2018 15:48:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=talk X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.91) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Jul 2018 15:48:37 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway31.websitewelcome.com (Postfix) with ESMTP id D323917AA1 for ; Tue, 31 Jul 2018 10:48:35 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id kWsafJ0m3kBj6kWsrfcEIk; Tue, 31 Jul 2018 10:48:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lRUBmTJWgld8uIANZHsIYjk47HBBhQR6Vl1wJ1XwEW8=; b=CodfFltfMDuIBW26GHU3xi+o2X j0EX8KV4opSCn7J940Rp4ZfvCY7WzsoHkvoM5f2N5OIc5G1bA/uoMjHlPTJfuKlVFxAKRUKf2JCDw cn6+gI9EieZDDzD3SEWMJ1Cho; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:47276 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fkWsa-003k4Q-A7; Tue, 31 Jul 2018 10:48:08 -0500 From: Tom Tromey To: Jan Vrany Cc: gdb-patches , Tom Tromey Subject: Re: [RFC] mi: add -a option to the "-data-disassemble" command References: <83effpubx5.fsf@gnu.org> <20180727075447.16243-1-jan.vrany@fit.cvut.cz> <87d0v469yy.fsf@tromey.com> <002372e4889b31236eb59b5a3414930cd0549346.camel@fit.cvut.cz> Date: Tue, 31 Jul 2018 15:48:00 -0000 In-Reply-To: <002372e4889b31236eb59b5a3414930cd0549346.camel@fit.cvut.cz> (Jan Vrany's message of "Tue, 31 Jul 2018 11:23:05 +0100") Message-ID: <87k1pb4dag.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00824.txt.bz2 >>>>> "Jan" == Jan Vrany writes: >> The indentation looked slightly off here. >> It could just be how the patch looked here, but could you double-check >> just in case? Jan> My fault. My editor put 8 spaces instead of tab (\t) at the beginning of Jan> my lines. Will fix. Thanks. According to .dir-locals.el, tabs are fine, assuming things line up properly. (But there's been talk over the years of switching purely to spaces, and IIRC using only spaces is also fine.) Jan> I'm sorry I'm confused. Let me try to explain. There are (now) four forms: Jan> 1a) -f filename -l linenum Jan> 1b) -f filename -l linenum -n lines Jan> 2) -s start-addr -e end-addr Jan> 3) -a addr Jan> Command must have one of the above four forms, otherwise it's invalid. Each Jan> "line" in the code above checks one of the above form (in order as written here). Jan> Note, that there's negation at the very beginning, so the condition holds Jan> if the command has none of the four forms. Seems "good" to me. Makes sense? Yes, thanks for explaining this. I was misreading the new code here. Jan> Now, it appears to me that first two lines can be merged as forms 1a and 1b differ only Jan> in presence of lines. Also, I forgot to update the comment above. So, what about: [...] Thank you, that seems like a good improvement. Tom