Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Joel Brobecker <brobecker@adacore.com>,
	 gdb-patches@sourceware.org,
	 Jerome Guitton <guitton@adacore.com>
Subject: Re: [RFA v2] arm-pikeos: software single step
Date: Mon, 10 Sep 2018 20:53:00 -0000	[thread overview]
Message-ID: <87k1ntrs61.fsf@tromey.com> (raw)
In-Reply-To: <ce2c969d1a69d92fd8ef38c1625520d4@polymtl.ca> (Simon Marchi's	message of "Mon, 10 Sep 2018 21:01:45 +0100")

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> (not sure why the From address is y@eu.adacore.com, I'll replace it
Simon> with Joel's).

>> +  symbol_table = (asymbol **) xmalloc (storage_needed);
>> +  make_cleanup (xfree, symbol_table);

Simon> It would make Tom really happy if you could avoid introducing a
Simon> cleanup :).

Wow, thanks.  I sometimes check patches for new cleanups but I totally
missed it in this one :)

Tom


  reply	other threads:[~2018-09-10 20:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10 15:13 [RFA] " Joel Brobecker
2018-09-10 17:28 ` Tom Tromey
2018-09-10 17:43   ` Joel Brobecker
2018-09-10 18:39     ` [RFA v2] " y
2018-09-10 20:01       ` Simon Marchi
2018-09-10 20:53         ` Tom Tromey [this message]
2018-09-11  8:56         ` Joel Brobecker
2018-09-11  9:58           ` Simon Marchi
2018-09-11 13:51             ` Joel Brobecker
2018-09-11 15:41           ` Tom Tromey
2018-09-11 21:17             ` Joel Brobecker
2018-09-14  0:47               ` Joel Brobecker
2018-09-14 10:57                 ` Simon Marchi
2018-11-01 21:44                 ` Joel Brobecker
2018-09-11  9:08 ` [RFA] " Pedro Alves
2018-09-11 11:04   ` Joel Brobecker
2018-09-11 11:27     ` Pedro Alves
2018-09-11 20:57       ` Joel Brobecker
2018-09-12 13:22         ` Pedro Alves
2018-09-14  0:38           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1ntrs61.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guitton@adacore.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox