From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3847 invoked by alias); 15 Sep 2018 20:35:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3838 invoked by uid 89); 15 Sep 2018 20:35:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=kindly X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 15 Sep 2018 20:35:12 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBC2B305D64C; Sat, 15 Sep 2018 20:35:10 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0862863F9C; Sat, 15 Sep 2018 20:35:09 +0000 (UTC) From: Sergio Durigan Junior To: Romain Naour Cc: Joel Brobecker , Tom Tromey , Pedro Alves , GDB Patches , Rich Felker , Thomas Petazzoni , Romain Naour Subject: Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c References: <20180912173113.2007-1-sergiodj@redhat.com> <6ee45c62-9bb6-c41a-b76e-0a9bf9c2c281@redhat.com> <874leulhqt.fsf@redhat.com> <203b1739-3418-2aa4-c40e-c2e63e717297@smile.fr> <87h8ir3gg6.fsf@tromey.com> <87in37oimf.fsf@redhat.com> <6e01d5ff-42bb-e1fc-162c-aa3fe97cf6b2@smile.fr> <20180914220940.GB26509@adacore.com> <1b59da32-0fa0-fd8f-ddd6-507e45df2988@smile.fr> Date: Sat, 15 Sep 2018 20:35:00 -0000 In-Reply-To: <1b59da32-0fa0-fd8f-ddd6-507e45df2988@smile.fr> (Romain Naour's message of "Sat, 15 Sep 2018 15:15:37 +0200") Message-ID: <87k1nmcxdu.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00499.txt.bz2 On Saturday, September 15 2018, Romain Naour wrote: >> - And the commit should have a corresponding GDB PR number >> (https://sourceware.org/bugzilla/); the PR number acts as >> a reference for "what's changed" in each corrective release, >> so the clearer the explanation in the description, the better. >> >> If you are the one motivated for the backport, it would be >> helpful if you could take care of creating the PR. Sergio >> offered to then backport it for you, but I can also help >> with that. > > I'm agree on the principle but the change from gdb 8.2 introducing the issue has > been backported to gdb 8.1.x [1] without such GDB PR number (as far I can see). > IIUC, all patches backported to a stable branch must have a GDB PR number. > This is not always the case. It is always the case. Joel kindly reminded me (back then) that I had forgotten to create a PR for this backport: https://sourceware.org/ml/gdb-patches/2018-03/msg00001.html And I did it subsequently: https://sourceware.org/bugzilla/show_bug.cgi?id=22907 Unfortunately, it was not possible to reference the PR number in the commit log anymore, but it was included in the official release note: https://sourceware.org/ml/gdb-announce/2018/msg00002.html Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/