From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109443 invoked by alias); 1 Nov 2018 22:16:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108540 invoked by uid 89); 1 Nov 2018 22:16:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:673, our X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Nov 2018 22:16:10 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway33.websitewelcome.com (Postfix) with ESMTP id C7DF41FB6018 for ; Thu, 1 Nov 2018 17:11:32 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ILBcgAdoQRPojILBcgOIvA; Thu, 01 Nov 2018 17:11:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ta7dkNVXiZHIesTM1MewrJtoP8MdJ7jFMPdQJw7RQZA=; b=Vc9XkAj5mXynz8pVr+Xe8FaJb3 OnR5RkgmSl0WMVi9g3TERhiVs0dEy2tamyLMfMVcQdn6aUSITW/faCpuxIIttr1GYDoYOHpMdQcVv 0bOJIpDu+viDzAln/WNfYVaZG; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:41966 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gILBc-002OPw-Gl; Thu, 01 Nov 2018 17:11:32 -0500 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits References: <20181024162037.21024-1-tom@tromey.com> <20181101153517.GA2705@adacore.com> Date: Thu, 01 Nov 2018 22:16:00 -0000 In-Reply-To: <20181101153517.GA2705@adacore.com> (Joel Brobecker's message of "Thu, 1 Nov 2018 08:35:17 -0700") Message-ID: <87k1lw8n3g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00014.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> I tested your change through our testsuite on the various baremetal Joel> targets we have, and noticed that it causes regressions on ppc and arm Joel> targets. It's hopefully something small, but just being back from Joel> a holiday, I'm a bit tied up at work; I'll put that issue on my TODO Joel> list to look at further. Thanks. To reproduce the problem I saw, just rebuild with -fsanitize=address and run the gdb.ada tests. I don't recall exactly which ones failed, but you should definitely see a read off the end of the source buffer. Tom