From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27474 invoked by alias); 30 Dec 2018 15:55:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27464 invoked by uid 89); 30 Dec 2018 15:55:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 30 Dec 2018 15:55:01 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 1C57AE5C9 for ; Sun, 30 Dec 2018 09:54:59 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ddQZgG4vZYTGMddQZg3JkJ; Sun, 30 Dec 2018 09:54:59 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IjmWZhl0uLdbdz7uenzahH8sM4CaX6I0V1GV218SXXo=; b=KymRRtSVH4umXIpOZVfu5h272R ij8nW5ucKpYDSuqIR5NQ7LSHRajeDSl31qKfiyq41ne9TZNVF1cNAgE6BroBkHWttT5/9lE7UEMb/ uU1HgOc2FXCWx9ppTDrJGfh/X; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:40660 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gddQY-001lKa-QL; Sun, 30 Dec 2018 09:54:58 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Fix leak in most gdb.mi tests. References: <20181229170116.8588-1-philippe.waroquiers@skynet.be> <87a7kom9ez.fsf@tromey.com> <871s60m8lg.fsf@tromey.com> <87wonsktj2.fsf@tromey.com> <1546162107.12900.3.camel@skynet.be> Date: Sun, 30 Dec 2018 15:55:00 -0000 In-Reply-To: <1546162107.12900.3.camel@skynet.be> (Philippe Waroquiers's message of "Sun, 30 Dec 2018 10:28:27 +0100") Message-ID: <87k1jrko1a.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2018-12/txt/msg00436.txt.bz2 >>>>> "Philippe" =3D=3D Philippe Waroquiers = writes: Philippe> The patch looks nice to me.=C2=A0=C2=A0I re-run all gdb.mi tests = under valgrind, Philippe> and no errors/no leak of the line_buffer. Philippe> A minor comment below. Thanks for taking a look. >> @@ -594,7 +594,7 @@ command_handler (const char *command) >> line ends in a backslash). Takes ownership of RL. */ Philippe> Remove the part of the comment about ownership ? I'm checking it in with this change. Tom