From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14296 invoked by alias); 10 Apr 2019 02:26:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14021 invoked by uid 89); 10 Apr 2019 02:25:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:559 X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.200) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Apr 2019 02:25:51 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 9314227CE59 for ; Tue, 9 Apr 2019 21:25:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id E2vphSWqE90onE2vphezD7; Tue, 09 Apr 2019 21:25:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HIoU90wxfeaPBfkrJQWBPf7sV1lXsyaV3emoVFCYCoU=; b=H7Mbyouz00lNOt5xy9BWeJD6hx K16p332vNv6/w+dGKqIzsmQ9jn4cXjGXGsnnLnpMztG7riEMnITs1Gu4XeIoJteMEgDQjH9YoAiq7 5BMivjofha214SXQN5WVu1Q+R; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:60844 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hE2vp-000xrr-C9; Tue, 09 Apr 2019 21:25:45 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Remove some uses of "object_files" References: <20190409180945.21621-1-tom@tromey.com> <20190409180945.21621-2-tom@tromey.com> <386c2247-82ff-bb68-92b2-1680d2f0b997@simark.ca> Date: Wed, 10 Apr 2019 02:26:00 -0000 In-Reply-To: <386c2247-82ff-bb68-92b2-1680d2f0b997@simark.ca> (Simon Marchi's message of "Tue, 9 Apr 2019 21:49:03 -0400") Message-ID: <87k1g2eguv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00173.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> LGTM. I would even suggest replacing the remaining few instances Simon> of object_files with current_program_space->objfiles_head and Simon> removing the macro completely. Yeah, I'll do it, though I think not as part of this patch. Some of the remaining uses are in objfile destructor, and I was working toward changing how objfiles are stored (using std::list rather than an intrusive list) but I haven't finished those patches yet... Tom