From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93157 invoked by alias); 6 May 2019 13:57:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92621 invoked by uid 89); 6 May 2019 13:57:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*RU:sk:gateway, HX-Spam-Relays-External:sk:gateway, HX-HELO:sk:gateway, H*RU:cmsmtp X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 May 2019 13:57:32 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 9E0C14B204 for ; Mon, 6 May 2019 08:57:29 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Ne7VhxUHH2qH7Ne7VhFa4R; Mon, 06 May 2019 08:57:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=N3YRmFofE3UVS38yuqilikGStXUq1Uv2qVia1TlB/Sk=; b=RwuYDQKGkny9rgU4+WgSouAKi3 dBtWfhlQjSH+UUHG7fNfMcZUAbyCD0xwbtTa0+pyxsxJ0Mo7lunVcvkKGu79+dxA1tN77noTMbtvT aqtN3gO7/CQK/wJ6BEApCR+iW; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:41000 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hNe7V-001OaS-6O; Mon, 06 May 2019 08:57:29 -0500 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] gdb: Update type of lower bound in value_subscripted_rvalue References: Date: Mon, 06 May 2019 13:57:00 -0000 In-Reply-To: (Andrew Burgess's message of "Sun, 5 May 2019 21:57:00 +0100") Message-ID: <87k1f3ofcn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00166.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> The dynamic lower (and upper) bounds of ranges are stored as type Andrew> LONGEST (see union dynamic_prop_data in gdbtypes.h). In most places Andrew> that range bounds are handled they are held in a LONGEST, however in Andrew> value_subscripted_rvalue the bound is placed into an int. Andrew> This commit changes value_subscripted_rvalue to use LONGEST, there Andrew> should be no user visible changes after this commit. Andrew> gdb/ChangeLog: Andrew> * valarith.c (value_subscripted_rvalue): Change lowerbound Andrew> parameter type from int to LONGEST. Andrew> * value.h (value_subscripted_rvalue): Likewise in declaration. Thanks, this looks good to me. Tom