From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66342 invoked by alias); 7 Jun 2019 18:09:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66334 invoked by uid 89); 7 Jun 2019 18:09:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.200) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Jun 2019 18:09:16 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id D3046135C8F for ; Fri, 7 Jun 2019 13:09:14 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ZJIght8RXdnCeZJIghWE8O; Fri, 07 Jun 2019 13:09:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CmFAY8lvH7xmOXb+SCEufBAL+64UXGhr9liNwBdahCs=; b=op5T3t/EPu+fJKb3R3NBqOgh36 d9q5U3IVRTpTSj3YdBeBPoWQ4Wd3lIAXi+inEeu03Wm0Du3RDtHZjfzUZe+CUz7PvFHcJnSDm5Qjh /0YOg+lkcFLzr04TjiwWZv+LQ; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:48736 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hZJIg-002R0H-KD; Fri, 07 Jun 2019 13:09:14 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/3] Implement info sources args [-d | -b] [--] [REGEXP] References: <20190331190803.7248-1-philippe.waroquiers@skynet.be> <20190331190803.7248-2-philippe.waroquiers@skynet.be> Date: Fri, 07 Jun 2019 18:09:00 -0000 In-Reply-To: <20190331190803.7248-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sun, 31 Mar 2019 21:08:01 +0200") Message-ID: <87k1dx6zee.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00160.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> 2019-03-31 Philippe Waroquiers Philippe> * symtab.c (struct output_source_filename_data): New members Philippe> regexp, c_regexp, dirname, basename. Philippe> (output_source_filename): Use new members to decide to print file. Philippe> (extract_info_sources_args): New function. Philippe> (print_info_sources_header): New function. Philippe> (info_sources_command): Read new optional arguments. Philippe> (_initialize_symtab): Update info sources help. This looks essentially good, but I think it should wait for Pedro's argument-parsing series and then be rewritten to take advantage of that. Tom