From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85949 invoked by alias); 2 Jul 2019 17:55:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85306 invoked by uid 89); 2 Jul 2019 17:55:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:602 X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.194.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 Jul 2019 17:55:50 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 7A210400D0577 for ; Tue, 2 Jul 2019 12:18:18 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id iN0Phzb6nYTGMiN0PhsksX; Tue, 02 Jul 2019 12:55:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iAWiYnTrE7bu69fUfobQtauPMUDwkb/9t8yenyUzCNE=; b=U+On6ZJ6XYYPTqedBQC+jYFcSy UVFfAXnCHBASBF4fC3JGjYRr/BN4EN3fkLILPNBcl8D3BIJqOR1GZ5m7m9NkemimSfyj3lqFPd3r1 xI/O/BuFQ5tHA+8VHe13YeyWy; Received: from 174-29-48-143.hlrn.qwest.net ([174.29.48.143]:60272 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hiN0O-003vFY-Qp; Tue, 02 Jul 2019 12:55:48 -0500 From: Tom Tromey To: Simon Marchi Cc: Andrew Burgess , gdb-patches@sourceware.org, Sergio Durigan Junior , Pedro Alves Subject: Re: [PATCH] gdb: Remove a non-const reference parameter References: <20190629145820.GR23204@embecosm.com> <20190702152119.31612-1-andrew.burgess@embecosm.com> Date: Tue, 02 Jul 2019 17:55:00 -0000 In-Reply-To: (Simon Marchi's message of "Tue, 2 Jul 2019 11:35:27 -0400") Message-ID: <87k1d0l3rw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00063.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> So I was the one who added this rule to the guide. When I asked for opinions and Simon> didn't get any, I thought it was because it wasn't very controversial and chose to add it. Simon> Since then, Pedro mentioned a few times he didn't agree with it. Simon> I'd like to know what others think, should we keep it (and enforce it) or remove it? Pedro raised good points on this topic, but in this particular case I think the code is clearer without modifying the parameter. Tom