From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH v2] Allow passing a block to lookup_global_symbol_from_objfile
Date: Wed, 24 Jul 2019 13:59:00 -0000 [thread overview]
Message-ID: <87k1c7v8hw.fsf@tromey.com> (raw)
In-Reply-To: <20190723014632.147552-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Mon, 22 Jul 2019 20:46:32 -0500")
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
Christian> This has no behavior change in itself, but allows a future patch
Christian> to add a function to the Python API to look up symbols in the
Christian> static block.
Thanks. This looks good to me, and I think you've addressed all the
earlier comments. So, this is ok.
Tom
next prev parent reply other threads:[~2019-07-24 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 19:07 [PATCH] " Christian Biesinger via gdb-patches
2019-07-22 20:59 ` Andrew Burgess
2019-07-22 21:00 ` Christian Biesinger via gdb-patches
2019-07-23 0:54 ` Simon Marchi
2019-07-23 1:46 ` [PATCH v2] " Christian Biesinger via gdb-patches
2019-07-24 13:59 ` Tom Tromey [this message]
2019-07-25 0:05 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1c7v8hw.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox