From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4844 invoked by alias); 10 Sep 2019 15:15:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4759 invoked by uid 89); 10 Sep 2019 15:15:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:996 X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.218) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Sep 2019 15:15:13 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 0FFA910AD1 for ; Tue, 10 Sep 2019 10:15:03 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 7hrCiymgC3Qi07hrCibXaT; Tue, 10 Sep 2019 10:15:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MJI9D8bA+7i3ozp8N5yng/CblhTYK3/j6WdcTvw4Fqg=; b=bl4ddyQEc3Pxz+1X+4etNLd3GI BEvHfQQESBFK2880b8ahx9UtCtf0fTQKUQTpCYCftlRW691HiSJ+SG8B8Q/6TMbUNOJ985CBAOxWN rj2vqger0ltVQuL3B9vzmDGEY; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:57524 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i7hrC-003RWq-0X; Tue, 10 Sep 2019 10:15:02 -0500 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH 2/3] Factor out the code to do the datadir-relocation for gdbinit References: <20190909180830.215313-1-cbiesinger@google.com> <20190909180830.215313-3-cbiesinger@google.com> Date: Tue, 10 Sep 2019 15:15:00 -0000 In-Reply-To: <20190909180830.215313-3-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Mon, 9 Sep 2019 13:08:29 -0500") Message-ID: <87k1ag6v4b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00159.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> This simplifies get_init_files and makes it possible to reuse Christian> this code in an upcoming patch for SYSTEM_GDBINIT_DIR. Christian> +static std::string Christian> +relocate_gdbinit_path_maybe_in_datadir (const std::string& file) Christian> +{ New functions should have an introductory comment. Christian> + for (; IS_DIR_SEPARATOR (file[start]); ++start) Christian> + continue; Just omit the "continue" and leave a bare ";". Christian> + relocated_path = std::string (gdb_datadir) + SLASH_STRING + Christian> + file.substr(start); This needs parens on the RHS and should be indented differently. Also, space before the "(" after "substr". Christian> + std::string relocated_sysgdbinit = Christian> + relocate_gdbinit_path_maybe_in_datadir (SYSTEM_GDBINIT); "=" at start of continuation line. Tom