From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103082 invoked by alias); 21 Jan 2020 20:17:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103073 invoked by uid 89); 21 Jan 2020 20:17:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=George, george, states X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Jan 2020 20:17:47 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway32.websitewelcome.com (Postfix) with ESMTP id E5FDA11DC655 for ; Tue, 21 Jan 2020 14:17:45 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id tzy5ibGqmiJ43tzy5ipQPM; Tue, 21 Jan 2020 14:17:45 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gCnDBkDRaauG6BNMwTVf9bzX3ARnTUmOrrWIwoHMiow=; b=fM7rAW3YbNRr8OAKqru8V99IS+ c7gx7GOxC9JOeCi5ePt1lnNxkuKqKjycRT/08VSmZTtT+gSuK7168sEAxT+ONNgGutPjzVD02Q5l1 t4UuvtJp8h02a0xOw436UHuvl; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:60710 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1itzy5-002Lfl-Ia; Tue, 21 Jan 2020 13:17:45 -0700 From: Tom Tromey To: George Barrett Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix Python probe breakpoints References: Date: Tue, 21 Jan 2020 20:23:00 -0000 In-Reply-To: (George Barrett's message of "Sun, 8 Dec 2019 03:46:18 +1100") Message-ID: <87k15k8syf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00649.txt.bz2 >>>>> "George" == George Barrett writes: George> The documentation for the `spec' variant of the gdb.Breakpoint George> constructor states that the accepted format is the same as the break George> command. However, using the -probe qualifier at the beginning of the George> breakpoint specifier causes a GDB internal error as it attempts to George> decode a probe location in the wrong code path. Without this George> functionality, there doesn't appear to be another way to set breakpoints George> on probe points from Python scripts. Thank you for the patch. George> gdb/ChangeLog: George> 2019-12-08 George Barrett George> Fix Python probe breakpoints. George> * breakpoint.c: Make bkpt_probe_breakpoint_ops non-static. George> * breakpoint.h: Add declaration for bkpt_probe_breakpoint_ops. George> * python/py-breakpoint.c: Use probe ops if the specifier is a George> probe specifier. George> gdb/testsuite/ChangeLog: George> 2019-12-08 George Barrett George> Test Python probe breakpoints. George> * gdb.python/py-breakpoint.c: Add probe point. George> * gdb.python/py-breakpoint.exp: Add probe specifier test. I wasn't sure about this approach, but after some reflection, I guess I can accept it. Mostly I was concerned that the Python API here would be sort of ugly. But, maybe it's not so bad. So, this is ok. Tom