Re: [PATCH] Fix for the complaint observed when symbol reading due to unsupported .debug_names form.

Tom Tromey
2020-05-07T13:26:06Z

>>>>> ">" == nitachra <Nitika.Achra@amd.com> writes:

>> Following complaint is observed with the executable compiled with -gdwarf-5
>> and -gpubnames flags- "During symbol reading: Unsupported .debug_names form
>> DW_FORM_ref4". This is the form corresponding to DW_IDX_die_offset attribute.
>> This patch fixes this complaint. Tested with clang 10.0.0. Test case used-

>> int main()
>> {
>> int sum,a,b;
>> sum = a + b;
>> return sum;
>> }

Does it fail some existing test in the gdb testsuite?
Normally what we like to see is either that a patch fixes some existing
failure (perhaps when the test suite is run in a certain way); or a new
test that fails before the patch and passes afterward.

>> + case DW_IDX_die_offset:
>> + /* In a per_cu index, index entries without CU attribute implicitly refer to the

This line looks too long to me.

Tom