From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.64.36]) by sourceware.org (Postfix) with ESMTPS id 28A7F386F44C for ; Thu, 7 May 2020 13:26:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 28A7F386F44C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway20.websitewelcome.com (Postfix) with ESMTP id AA3C5400CECDA for ; Thu, 7 May 2020 07:08:06 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id WgXNjs92HAGTXWgXNj8z22; Thu, 07 May 2020 08:26:05 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fydIeFmOzjP81QQvMSfytpth+E005xSQcAUO11BAyQ4=; b=VlfAJfdBxn8/fDmWvHppEPDuKH hnVhqkWZGVn3FY0Vgc2N3KiVMx2Kr8VHiBnCKVZtRLdKxroqShAhV28MQ/7a5BF5BXUjvKDiOZ9DR NOMLuxO/8aJrt5cYK5K8zY0VN; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:34282 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jWgXN-000dLn-Bh; Thu, 07 May 2020 07:26:05 -0600 From: Tom Tromey To: nitachra Cc: gdb-patches@sourceware.org, JiniSusan.George@amd.com Subject: Re: [PATCH] Fix for the complaint observed when symbol reading due to unsupported .debug_names form. References: <20200504061319.3699-1-Nitika.Achra@amd.com> X-Attribution: Tom Date: Thu, 07 May 2020 07:26:04 -0600 In-Reply-To: <20200504061319.3699-1-Nitika.Achra@amd.com> (nitachra's message of "Mon, 4 May 2020 11:43:19 +0530") Message-ID: <87k11nzxjn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jWgXN-000dLn-Bh X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:34282 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 May 2020 13:26:16 -0000 >>>>> ">" == nitachra writes: >> Following complaint is observed with the executable compiled with -gdwarf-5 >> and -gpubnames flags- "During symbol reading: Unsupported .debug_names form >> DW_FORM_ref4". This is the form corresponding to DW_IDX_die_offset attribute. >> This patch fixes this complaint. Tested with clang 10.0.0. Test case used- >> int main() >> { >> int sum,a,b; >> sum = a + b; >> return sum; >> } Does it fail some existing test in the gdb testsuite? Normally what we like to see is either that a patch fixes some existing failure (perhaps when the test suite is run in a certain way); or a new test that fails before the patch and passes afterward. >> + case DW_IDX_die_offset: >> + /* In a per_cu index, index entries without CU attribute implicitly refer to the This line looks too long to me. Tom