From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway32.websitewelcome.com (gateway32.websitewelcome.com [192.185.144.98]) by sourceware.org (Postfix) with ESMTPS id 113283857C4D for ; Tue, 1 Sep 2020 14:23:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 113283857C4D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 1D5E05B11 for ; Tue, 1 Sep 2020 09:23:10 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id D7BmkENQOBD8bD7Bmkbetf; Tue, 01 Sep 2020 09:23:10 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pniv/ECGVIFIiVfz5L0RTFqouL+O54+RdLpPk3HjfjE=; b=CIid1CJhEqteznvfUpf/ZLxSJG pbYEcGGKIfqsPVhvyFocTrTmDDqDubCkLjKnA/vKiazGm0fIW8ednxzgvuYGFd2vASSvk+zIvZFxc n6G/yk0UwF3f6sqdNO6clyA49; Received: from 71-218-12-75.hlrn.qwest.net ([71.218.12.75]:54954 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kD7Bl-000HCI-Oz; Tue, 01 Sep 2020 08:23:09 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Have partial symbol tables own psymbol vectors References: <20200828193304.17475-1-tom@tromey.com> <871rjo7xic.fsf@tromey.com> <87sgc27nez.fsf@tromey.com> X-Attribution: Tom Date: Tue, 01 Sep 2020 08:23:07 -0600 In-Reply-To: (Simon Marchi's message of "Mon, 31 Aug 2020 17:39:39 -0400") Message-ID: <87k0xd7f04.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.218.12.75 X-Source-L: No X-Exim-ID: 1kD7Bl-000HCI-Oz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-218-12-75.hlrn.qwest.net (bapiya) [71.218.12.75]:54954 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2020 14:23:13 -0000 Simon> I think it would be a good time to get rid of the objfile Simon> parameter in the add_psymbol methods. This parameter shouldn't Simon> be there if the partial symtabs are really objfile-independent. Yeah. I have another patch to remove it from end_psymtab_common, but I didn't look at removing it from the add_psymbol methods. I think it's a good idea, but it might be a pain to pipe the object everywhere it is needed. So I'd prefer to do this as a separate patch. Simon> The other use of objfile in partial_symtab::add_psymbol is for Simon> stats. I think that could be easily implemented some other way Simon> that doesn't require passing the objfile. I feel like the stats are not very useful and could just be removed. I have never once used them; the bcache already tracks its own efficiency; and gdb already knows how many psymbols actually exist. Tom