Re: [PATCH] gdb: print size of downloaded debuginfod binary

Tom Tromey
2020-12-15T20:29:24Z

>> Seems like a bit of a shame to have an optional here, but then
>> essentially require optional-style behavior in the CLI ui-out as well
>> (in deferring output until the first update).

Tom> Well, the natural place to declare "ui_out::progress_meter meter" given
Tom> its lifetime is in debuginfod_source_query and debuginfod_debuginfo_query.

Tom> But the only constructor has the name argument with no means of changing
Tom> it later, and the name (containing the size) is only known lateron, when
Tom> progressfn is called.

Makes sense to me.

This looks good. Thanks for doing this.

Tom