From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id X7OOKKTG01/LbQAAWB0awg (envelope-from ) for ; Fri, 11 Dec 2020 14:21:08 -0500 Received: by simark.ca (Postfix, from userid 112) id 9A26E1F0A9; Fri, 11 Dec 2020 14:21:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4053B1E590 for ; Fri, 11 Dec 2020 14:21:08 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B7B9E3972C18; Fri, 11 Dec 2020 19:21:07 +0000 (GMT) Received: from gateway32.websitewelcome.com (gateway32.websitewelcome.com [192.185.145.107]) by sourceware.org (Postfix) with ESMTPS id 60D293857037 for ; Fri, 11 Dec 2020 19:21:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 60D293857037 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway32.websitewelcome.com (Postfix) with ESMTP id B022733727 for ; Fri, 11 Dec 2020 13:21:02 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id nnyQkX7vQnPrxnnyQkqygC; Fri, 11 Dec 2020 13:21:02 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=L0LzmDSZmh4uv3ltprOv0/Xbj5a7Sd6xbgOFRkXr+Js=; b=hWBB92HY9mbDyhGKdYXHmjuDP2 tzYpVVLH8vTCB9yFCKfVcNGLQFc7Sg1Q5XFhpWJ07TbXH5RGzXr7Rex8S5m0bBjh/WWO0CR21rHsB YHDM3L8W0s9XS0cRro5HnZ2Xh; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:40328 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1knnyQ-0042Sh-Dz; Fri, 11 Dec 2020 12:21:02 -0700 From: Tom Tromey To: Tom de Vries Subject: Re: [gdb/cli] Add a progress meter References: <6ad82f30-0ca3-8b19-2907-d71f0dfecafe@suse.cz> <2c28a403-a169-0dc3-9b64-58484237c8c2@suse.cz> <72061fbb-b480-04ce-ef4a-fe13a7266885@suse.de> <87a6ulmppr.fsf@tromey.com> <5506b198-c504-0046-0559-bcc24538d31c@suse.de> X-Attribution: Tom Date: Fri, 11 Dec 2020 12:21:01 -0700 In-Reply-To: <5506b198-c504-0046-0559-bcc24538d31c@suse.de> (Tom de Vries's message of "Fri, 11 Dec 2020 18:51:45 +0100") Message-ID: <87k0togndu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1knnyQ-0042Sh-Dz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:40328 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> I've taken a look, and think that this code is more in line with gdb cli Tom> setup, so I've reimplemented on top of this. Tom> Here is the first patch, adding the progress meter infrastructure Tom> factored out from your patch. Not sure if I ought to review a patch that I largely wrote, but I did find some things I think should be done differently nowadays. Tom> +void Tom> +cli_ui_out::do_progress_start (const std::string &name, int should_print) should_print should probably be a bool, throughout this patch. Tom> + /* Don't actually emit anything until the first call notify us I think s/notify/notifies/ Tom> + if (!stream->isatty ()) Tom> + { Tom> + fprintf_unfiltered (stream, "%s...", meter.name.c_str ()); This is probably fine but I suppose the meaning of "should_print" ought to be described somewhere, since otherwise this could seem like a bug -- it is printing something even when should_print==false. Tom> + m_meters.push_back (meter); std::move(meter) would be more efficient here, since it would avoid another string copy. Tom> + progress_meter (struct ui_out *uiout, const std::string &name, Tom> + int should_print) Tom> + : m_uiout (uiout) Here's probably where should_print should be documented. Tom> +get_chars_per_line (void) Just "()", not "(void)", now. Tom> +++ b/gdb/utils.h Tom> @@ -364,6 +364,10 @@ extern void wrap_here (const char *); Tom> extern void reinitialize_more_filter (void); Tom> +/* Return the number of characters in a line. */ Tom> + Tom> +extern int get_chars_per_line (void); Here too. Tom