From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QvhHL2XefWAHfQAAWB0awg (envelope-from ) for ; Mon, 19 Apr 2021 15:47:49 -0400 Received: by simark.ca (Postfix, from userid 112) id B3D491F104; Mon, 19 Apr 2021 15:47:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 02DCE1E01F for ; Mon, 19 Apr 2021 15:47:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A876D394742B; Mon, 19 Apr 2021 19:47:48 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.145.87]) by sourceware.org (Postfix) with ESMTPS id 5B40C385E001 for ; Mon, 19 Apr 2021 19:47:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5B40C385E001 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id A1B64C4F6F0 for ; Mon, 19 Apr 2021 14:47:36 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id YZrslzosbmJLsYZrslORnE; Mon, 19 Apr 2021 14:47:36 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VAiY7+mQ9qa/PudQt7kdXuOcC88hFKGZ3Gp4NmP6v/U=; b=Og9GDl5TvLiSZXaODboubHmbEa skcoknhqq8Uu95L4TJs0A4cV9PznbCpsIU5QKPSNEoIFtflBElGMwdvMiVwmk3EFp9m8d0Jpk3bpC saC58dGHFtXeM0DTJMk1BowK8; Received: from 71-211-182-15.hlrn.qwest.net ([71.211.182.15]:60398 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lYZrs-0046kg-Bv; Mon, 19 Apr 2021 13:47:36 -0600 From: Tom Tromey To: Tom de Vries Subject: Re: [PATCH][gdb/build] Hardcode --with-included-regex References: <20210413153447.GA21719@delia> X-Attribution: Tom Date: Mon, 19 Apr 2021 13:47:35 -0600 In-Reply-To: <20210413153447.GA21719@delia> (Tom de Vries's message of "Tue, 13 Apr 2021 17:34:49 +0200") Message-ID: <87k0oycazs.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.182.15 X-Source-L: No X-Exim-ID: 1lYZrs-0046kg-Bv X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-182-15.hlrn.qwest.net (murgatroyd) [71.211.182.15]:60398 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> A note on the latter: it's actually a bug to compile a regex using regcomp and Tom> then pass it to re_search. The GNU regex interface requires one to use Tom> re_compile_pattern or re_compile_fastmap. But as long we're using one of the Tom> GNU regex incarnations in gnulib, glibc or libiberty, we get away with this. Tom> The PR could be fixed by adding -lc in a specific position in the link line, Tom> to force regcomp to be bound to glibc. But this solution was considered Tom> in the discussion in the PR as being brittle, and possibly causing problems Tom> elsewhere. Tom> Another solution offered was to restrict regex usage to posix, and no longer Tom> use the GNU regex API. This however could mean having to reproduce some of Tom> that functionality locally, which would mean maintaining the same Tom> functionality in more than one place. Just to be clear, using the GNU extensions isn't currently done, I think. I'd like to use them so GDB can avoid copying some strings to ensure they are \0-terminated; but this isn't done at the moment. So, it would also be equivalent, right now, to switch GDB to conform to POSIX here. Personally I'm fine with just requiring the libiberty regexp. That said we should probably see if there are differing opinions, or some reason to keep the flag. thanks, Tom