From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id j2xXBEXWkmCCCAAAWB0awg (envelope-from ) for ; Wed, 05 May 2021 13:30:45 -0400 Received: by simark.ca (Postfix, from userid 112) id 045181F11C; Wed, 5 May 2021 13:30:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 390F81E813 for ; Wed, 5 May 2021 13:30:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D5332383F412; Wed, 5 May 2021 17:30:43 +0000 (GMT) Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.149.62]) by sourceware.org (Postfix) with ESMTPS id 1EEC0384F03B for ; Wed, 5 May 2021 17:30:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1EEC0384F03B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 6348AAED3A for ; Wed, 5 May 2021 12:30:36 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id eLM4lRhOZL7DmeLM4lMhsS; Wed, 05 May 2021 12:30:36 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=42HbDYKEEvN6rQKQ96yQSFYUHX97pxZ9p3uhEebzTTM=; b=n78thpSrcwXK7ZertEHJb6dYZv B3jjYqB6KK3e5kYrrNUoZPPjnnlUZ/6UmsovjWeZfbalRtZqaI1yFJ/Lu+GFWI5tB153eR/BbjTnZ muzIkIwp9Jurb7mAPt55h2T3i; Received: from 97-122-70-176.hlrn.qwest.net ([97.122.70.176]:60178 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1leLM4-003WH4-3t; Wed, 05 May 2021 11:30:36 -0600 From: Tom Tromey To: Mike Frysinger via Gdb-patches Subject: Re: [PATCH/committed] sim: rl78: clean up various warnings References: <20210505030449.25159-1-vapier@gentoo.org> X-Attribution: Tom Date: Wed, 05 May 2021 11:30:35 -0600 In-Reply-To: <20210505030449.25159-1-vapier@gentoo.org> (Mike Frysinger via Gdb-patches's message of "Tue, 4 May 2021 23:04:49 -0400") Message-ID: <87k0odqe9w.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.176 X-Source-L: No X-Exim-ID: 1leLM4-003WH4-3t X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-176.hlrn.qwest.net (murgatroyd) [97.122.70.176]:60178 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Mike" == Mike Frysinger via Gdb-patches writes: Mike> Fix a logic error when processing commands where p was reassigned Mike> to cmd and then has its leading whitespace scanned a 2nd time. Mike> Handle short reads with fread(). Mike> - /* Find the extent of the command word. */ Mike> - for (p = cmd; *p; p++) Mike> - if (isspace (*p)) Mike> - break; Mike> - I'm not sure it makes sense to completely delete this. Perhaps instead just removing 'p = cmd' is correct? It looks to me that this code is trying to parse a command name followed by arguments. Like, ideally, "monitor trace on" should set cmd="trace" and args="on", but with the patch I don't think this will happen. Tom