Re: [PATCH] Use strwinerror in gdb/windows-nat.c

[Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>]

>>>>> "Jon" == Jon Turney <jon.turney@dronecode.org.uk> writes:

>> I'm checking this in now.

Jon> As is traditional by now, this breaks the Cygwin build.

Sorry about that.  I don't break Cygwin on purpose, but I also don't
have any way to do a test build.

Jon> I'd suggest the attached to fix this, but I don't think this qualifies
Jon> as obvious, since it's not obvious what USE_WIN32API is supposed to 
Jon> mean, so a review would be useful.

I don't fully know either, but this is what gdbsupport/common.m4 says:

  case ${host} in
    *mingw32*)
      AC_DEFINE(USE_WIN32API, 1,
		[Define if we should use the Windows API, instead of the
		 POSIX API.  On Windows, we use the Windows API when
		 building for MinGW, but the POSIX API when building
		 for Cygwin.])
      WIN32APILIBS="-lws2_32"

Jon> Commit 02d04eac "Use strwinerror in gdb/windows-nat.c" also moves
Jon> strwinerror() under the USE_WIN32API conditional, which is not defined
Jon> for Cygwin (and looks like it shouldn't be, as appears to imply
Jon> non-POSIX and MiNGW and WinSock...)

Jon> Also enable the declaration and definition of strwinerror() when
Jon> __CYGWIN__ is defined.

I'm not sure how this area ought to work on Cygwin.  The goal here is to
get a better error message when some Windows API fails.  If Cygwin can
use strwinerror, then this seems fine.  If not, I could write a patch to
stub this out for Cygwin, which would be the status quo ante.

Tom