From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NxI4NYRjFGb6YigAWB0awg (envelope-from ) for ; Mon, 08 Apr 2024 17:37:08 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bisquCru; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BF93E1E0C0; Mon, 8 Apr 2024 17:37:08 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9959B1E030 for ; Mon, 8 Apr 2024 17:37:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 088BD385DC3F for ; Mon, 8 Apr 2024 21:37:06 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2DC8C3858D28 for ; Mon, 8 Apr 2024 21:36:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DC8C3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2DC8C3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712612207; cv=none; b=j3o2BRrPnqg0OhK38XsTtjOmyY63QxeUbmeQ6jvy6mB36UgS7HLz4Q/7FOzbLrEsQ/BARHVxwTYsQU/extVaI9w7YfmzgNYMnHeQPwsDV5U+6uCLRe3nxUbcOe1IkO67qry4VyKKmg2keufub/eeDnq6hYp8XikgG2onrFiwV+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712612207; c=relaxed/simple; bh=CVXRo7FZU1JyYDH4iZEIJK0beim+rdf4sBVI0inG+EA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Jz2BFtZkkWr4w7dncI4yVf6hY9bzkhZYghDXl/Nl5iQkfr4lOVw0Y+RFogTFl1Yt0UQLsszwngOLa85K6tzgnnN4ujIwivewpm3vy2RNJttyULj4PkjhoMUDwJuvw518i4qRBFlUHbY32Sp+Ui6SLnfRGyCdTz0Olo+P8o9Silc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712612205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0MTDEEh9FBliVslI18znjQz9wzf84pNllBnsxfI25yE=; b=bisquCruoUEK5DRMI3a4tDoGo+wtpV3B/JdGe8k7IAt0Ng4JRDh82f+wQ+wyu6TzMd5QLu mTq5ZdpmyEISkwurFOHh04sCrS2ayVEw5Vym7b/EqV9HRBE74w6CakzMHTiaFIzjs1jOuh TzM024sCo2wg0uDmHLtvs3iGNYzVQKI= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-vYlB86SEPWuCiXIRzbPsuA-1; Mon, 08 Apr 2024 17:36:44 -0400 X-MC-Unique: vYlB86SEPWuCiXIRzbPsuA-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a51aec8eb93so187366266b.0 for ; Mon, 08 Apr 2024 14:36:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712612202; x=1713217002; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0MTDEEh9FBliVslI18znjQz9wzf84pNllBnsxfI25yE=; b=aMyjIrp7v+D5yq2CUNuH0QeqwNveDfO+SLCNwhaknxMPD2/dmniA4ZYL6En5DDEpyp BbqwV2H6Hd3zKYB1KCoDyAZvLqnhYiiCeTSFctFjAB1714x+zCejHMpb6tqdpc85IueO BKcaoGcWISTaB4c75uukU+nmQDL/VI5GFYTKC3Z39fJx7GIYwEfPmhhk7WQTNTsynxjY L7SqM1NByQtS+R6xMZ6OifGWTpOdpvvFVohPVlrBqvHVg9iNM5h3YPSbf6XdTlzp/B3t vNjok1Z1rG3/amFtnCjdnqIHvLMC0UG8IXK9xqf/ltB7Vbp7zbLFUQbxSOf2xvggM3kr cAgQ== X-Forwarded-Encrypted: i=1; AJvYcCX9cDtNousC49gcHmBmNWSU8grIcrjz8v80JSclbygCfUBqhmZPyMwk0JVK9kiJArfEmOyLp3/iC32eY+2DanGmWMlOwSlsB0Ci0Q== X-Gm-Message-State: AOJu0YzlvAVJjU9U5itG/UUr/+4ol0HHR6loZrrYJNZLlly/ZH4kpDZH s3ux9ePWO+zPNCvgAfdCt0Id6lJujCIZAFIUEN/Hj/EH0wy7QlAYyNRUHS5hFCl1rvoZi3I1vX4 vqWp2XGeXYp/oVQzi9ndJK9oJGBx5cUHYNGMkQWOIkOMljEnEgCx661rfRmmiKaxVGYk= X-Received: by 2002:a17:907:3e1a:b0:a51:dfb1:8bdc with SMTP id hp26-20020a1709073e1a00b00a51dfb18bdcmr1990030ejc.69.1712612202072; Mon, 08 Apr 2024 14:36:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIuaxdlaUS3dTwihjtiAqx7IHSPnaOGvvx/z6gkqN5GlKbaWkMCLTPi9jKDjTU7hJLtLYFCQ== X-Received: by 2002:a17:907:3e1a:b0:a51:dfb1:8bdc with SMTP id hp26-20020a1709073e1a00b00a51dfb18bdcmr1990014ejc.69.1712612201420; Mon, 08 Apr 2024 14:36:41 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id a13-20020a170906244d00b00a51be2b75f3sm3429218ejb.35.2024.04.08.14.36.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 14:36:41 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: Tom Tromey , "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" Subject: Re: [PATCH 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read In-Reply-To: <87il0vnbpb.fsf@tromey.com> References: <990be8b42f1f6ca33ffed7a8ae7ead327009d847.1710343840.git.tankut.baris.aktemur@intel.com> <87h6halypk.fsf@tromey.com> <87v85pkmkl.fsf@tromey.com> <87o7bagqil.fsf@tromey.com> <87jzlc2c4u.fsf@redhat.com> <87il0vnbpb.fsf@tromey.com> Date: Mon, 08 Apr 2024 22:36:40 +0100 Message-ID: <87jzl71qqf.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> The alternative to this would be to add a qSupported feature for the 'x' > Andrew> packet and choose m/x based on the qSupported reply. > > That's what his original patch did. If you think that's best then it > already exists. My view was that there didn't seem to be a need for > this to be in qSupported and the qSupported responses are already > getting pretty long. No, I joined this party a little late, so I missed that this was the original approach taken. I think the best solution would be to add a prefix character to the reply so that we never send back an empty packet (when this feature is supported), then use the empty packet to represent the unsupported case. Thanks, Andrew