From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0gMEDzViZ2aA/i4AWB0awg (envelope-from ) for ; Mon, 10 Jun 2024 16:29:41 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=mJyrTM+Z; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 33FDD1E0C1; Mon, 10 Jun 2024 16:29:41 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1A7DC1E092 for ; Mon, 10 Jun 2024 16:29:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CFBEF385DDC2 for ; Mon, 10 Jun 2024 20:29:38 +0000 (GMT) Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 5AF8D3858283 for ; Mon, 10 Jun 2024 20:29:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5AF8D3858283 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5AF8D3858283 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718051360; cv=none; b=ukO+vqthdqAflXdIS0c+mUjINkjclboljCbbg7s1dq1bW/sEazjXkLrPeDAwxf7aFrmCB1kBkA0y+veQcXqIIT46BFFRvg/+M+LxwiXVBR9DPUeBD6cn1enzI2MuwMWhOsE/UlWwRtiJJX5UQI+CbFHnQu7bQJzW5eBDJmIPgS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718051360; c=relaxed/simple; bh=ONd1fFh7Iz2PByRYmnxd2xigAFYo4ftjtHFwD7OKw6I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=RXtX6AxsDc0en+e4uuR93vizyBwtXA6V707joUONAVZ+wC9o0q7JRH7ZCFC2yq0oBbCwCunk7uOgYG2XMt5eytOlA2mKZvhPA/gKarQh3lOtg1rq0yUXKYGOxweUJz3xf6IL9zqzP/P4OBBDlC11AByMQxcxiNFUark/aVYQ2R0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTPS id GiQSsftu3AidIGldmsCIg5; Mon, 10 Jun 2024 20:29:18 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id GldlswsNlbZOgGldlsnoLY; Mon, 10 Jun 2024 20:29:17 +0000 X-Authority-Analysis: v=2.4 cv=Ffkxxo+6 c=1 sm=1 tr=0 ts=6667621d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=T1WGqf2p2xoA:10 a=Qbun_eYptAEA:10 a=RtkggBvCAAAA:8 a=Twlkf-z8AAAA:8 a=NEAV23lmAAAA:8 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=6kiJ4XN7jcj-wn83mYAA:9 a=-74SuR6ZdpOK_LpdRCUo:22 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Q12OgLZfgrt4GgZ72y8yhYCNAh49m3CGp9ngpsHhDso=; b=mJyrTM+ZRnaula2D+GOcBa581q yuSw2CDm8l88VSibc9wbuqZcjiV7Teim+S52xBWS1GFWDQ2H4Cg5DNRFR79L/RqzP4YuhxZ1C0Oge Nrxbf6iQ7f1fSbplhvgFU3Rxl; Received: from 75-166-134-4.hlrn.qwest.net ([75.166.134.4]:44552 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1sGldk-002Kj2-2n; Mon, 10 Jun 2024 14:29:16 -0600 From: Tom Tromey To: Dmitry Neverov Cc: gdb-patches@sourceware.org Subject: Re: [PR 31727] Recognize -2 as a tombstone value in .debug_line In-Reply-To: <20240608084529.1406412-1-dmitry.neverov@jetbrains.com> (Dmitry Neverov's message of "Sat, 8 Jun 2024 10:45:29 +0200") References: <20240608084529.1406412-1-dmitry.neverov@jetbrains.com> X-Attribution: Tom Date: Mon, 10 Jun 2024 14:29:15 -0600 Message-ID: <87jziwilt0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.4 X-Source-L: No X-Exim-ID: 1sGldk-002Kj2-2n X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-4.hlrn.qwest.net (murgatroyd) [75.166.134.4]:44552 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKl1YeEhY0EqBlCwrAIBbV+pM7RmiTlz7Ni+QZKsT5l7oG9klv2H1xSid4loqmTlJVEQniHD9LAzn/FLWV8eumHG7PPsm3oqvk94UqanuT70BmUVGZvt 54363WNSm1dHy9CmVzlcnbr6i7nUj2zSjXcR1FJIj1fdnPUJvfwviSDwL6z/plaqAfbLI8DKRnnfVoeNlXrVQuy8YqXvOUAbO10= X-Spam-Status: No, score=-3014.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Dmitry" == Dmitry Neverov writes: Dmitry> Commit a8caed5d7faa639a1e6769eba551d15d8ddd9510 handled the tombstone Dmitry> value -1 used by lld (https://reviews.llvm.org/D81784). The Dmitry> referenced lld commit also uses the tombstone value -2 for Dmitry> pre-DWARF-v5 Dmitry> (https://github.com/llvm/llvm-project/commit/e618ccbf431f6730edb6d1467a127c3a52fd57f7). Dmitry> If not handled, -2 breaks the pc step range calculation and triggers Dmitry> the assertion: Dmitry> gdb/infrun.c:2794: internal-error: resume_1: Assertion Dmitry> `pc_in_thread_step_range (pc, tp)' failed. Dmitry> This commit adds -2 tombstone value and handles it in the same way as -1. Dmitry> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31727 I wonder if it's possible to write a test case for this using the DWARF assembler. If that looks too hard, though, I wouldn't bother, considering that the -2 approach is gone from lld now. In that case the patch is OK: Approved-By: Tom Tromey Tom