From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wJFyMUZkBmfqTQcAWB0awg (envelope-from ) for ; Wed, 09 Oct 2024 07:08:54 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PTLjuYo+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C32EB1E356; Wed, 9 Oct 2024 07:08:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 38C8B1E354 for ; Wed, 9 Oct 2024 07:08:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC7BE385020B for ; Wed, 9 Oct 2024 11:08:53 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id EAC36385DC1E for ; Wed, 9 Oct 2024 11:08:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EAC36385DC1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EAC36385DC1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728472117; cv=none; b=jQfMS0l/xfq8v7/v2vaB41Z+751Av+kfgTii5c4+5bAVZRpfVUJBrlIVhMP/QItYjC43CAWb8QqbS/QKWxVATePo4p/sPE+JTj8cTgAd3iQDtR6cQdv45X7iUyvXs5ZOGwE4NC2HoRrF0X+tQ43rOrsXv3ysI7t7WJEbNg5wECU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728472117; c=relaxed/simple; bh=ose4Cgj4iRungZugmuD7vGIZ68UmYsNsZt+MaZSrq60=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UkhHjhi98jopjO70ITqYJtYq+5boWUQ+tBlV+6Fr0a4wb3+G873B1j1NnvrmufwrZIEDNFKIAR81TViALoG1T2XgE+VX0zLvBp5m6bBUfdtfcPfDR6sfzzNXRLab/GRgvIXzRszCw4Qe13nXU5tnOUwD5q3B2AtMsxZcaY8F2S4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728472115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WXs1uR5fwdUHOfyS/j9lSvS23+GYwRmBdP6nmUS/ZYw=; b=PTLjuYo+LstTO8gbMKcCw5V2CPO2zcebxA0RoLRRXBTyxNW5rTTE8ceJIc2IHSvEtNCPfp bfhtyoLFZla4kDBWahXjFa6VgVFlUoRYuNzbXhmyxcg6ES1IhTcDQlOoUMTPDl+Vg8tKmY xPn/6cwOOZeTPoRYDl3PrL6rjUhzYNE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-A2J-1diZMxmzUpy1DHUaew-1; Wed, 09 Oct 2024 07:08:34 -0400 X-MC-Unique: A2J-1diZMxmzUpy1DHUaew-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a9944a87bfcso272730666b.2 for ; Wed, 09 Oct 2024 04:08:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728472112; x=1729076912; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WXs1uR5fwdUHOfyS/j9lSvS23+GYwRmBdP6nmUS/ZYw=; b=HEY6/6YHEWRVtzoM+rfFKBmo3kKjmdgB+ULaB3AuUWAMK9YL6OKEOS57WJaZAKFwTW pmUJSWazlCieYJ81xePFlLHgJUOtsYo488CV95c9QIdjvuVNTOBDtquger16Hz28sNlo Yk4vPSTRuaq/zWd8/k+TfCN1SZT+w0gMiGsKbxh+f8NxqLusA9bmnYLNd09p/+bhy2/N FyWctV/e6ALZglfp2prJy2fMNRwDURpY9nyOMEMYTT2QXJeTLyLE1K+20Eqn3ooUfXDW qaAk7A3yTRU8B7xM1c46zZfZEIQyn8TjZja4c+7vohy3srbu7u/lWfCR3zD0RBpGA11H ZBog== X-Forwarded-Encrypted: i=1; AJvYcCWOJ+MYy8UF6WcvxWAcyp8jvRrqpQ24RLc8RDMpUWzegCjZQKQnt7m17MleGppjz1KrSA/JZzGRDFl4Xw==@sourceware.org X-Gm-Message-State: AOJu0YwLDo0qY4jKhkdy2ascJyJ7H4EuFdh0Fz3E6PVasVH/6bsV2Vka HRHWv5yzaMCg01smbfVE06JqvKAO8lMtBY6q1ZNpiUGoMY3c9EvauZdrFcm19dkKkRZv+HdfaG8 GDFPiNCMk4a/LEeFbBjBEzDoRxliuOG87QbXGa69JJjZYySmBPiESvkufot0BL0o4GmU= X-Received: by 2002:a17:907:7b9e:b0:a99:374e:f3cb with SMTP id a640c23a62f3a-a998d2ffc73mr189358466b.46.1728472112591; Wed, 09 Oct 2024 04:08:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGf1A17f0UoDKPUA0OajSd7CusIfQWsVsHV2FncGihtXRKc4R5PQE+5SAFvM1IhJhUJaLE0Ow== X-Received: by 2002:a17:907:7b9e:b0:a99:374e:f3cb with SMTP id a640c23a62f3a-a998d2ffc73mr189356566b.46.1728472112217; Wed, 09 Oct 2024 04:08:32 -0700 (PDT) Received: from localhost ([195.213.152.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a992e784ee4sm640048766b.105.2024.10.09.04.08.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 04:08:32 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb: make use of set_tdesc_osabi overload in features/ files In-Reply-To: References: <805ec50236bae86f1e7e1d77ceff99763ec00ba4.1728239729.git.aburgess@redhat.com> Date: Wed, 09 Oct 2024 12:08:31 +0100 Message-ID: <87jzehbkk0.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > On 2024-10-06 14:37, Andrew Burgess wrote: >> There are two versions of the set_tdesc_osabi function in GDB: >> >> void >> set_tdesc_osabi (struct target_desc *target_desc, const char *name) >> { >> set_tdesc_osabi (target_desc, osabi_from_tdesc_string (name)); >> } >> >> void >> set_tdesc_osabi (struct target_desc *target_desc, enum gdb_osabi osabi) >> { >> target_desc->osabi = osabi; >> } >> >> In the gdb/features/ files we call the second of these functions, like >> this: >> >> set_tdesc_osabi (result.get (), osabi_from_tdesc_string ("GNU/Linux")); >> >> This can be replaced with a call to the first set_tdesc_osabi >> function, so lets do that. I think that this makes the features/ code >> slightly simpler and easier to understand. >> >> There should be no user visible changes after this commit. > > Just a nit but... while at it, couldn't we change them to use the > enumerator directly, to save lookups at runtime? > > set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); > > I guess we would need a enum -> string (GDB_OSABI_LINUX -> > "GDB_OSABI_LINUX") function, which we have for other enums. We just > don't have it for this enum yet. Another case for adding a "magic enum" > library :). This was Luis' request. See v2 my attempt at this. Thanks, Andrew