From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id COTCKLOMP2doyjkAWB0awg (envelope-from ) for ; Thu, 21 Nov 2024 14:40:35 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=f3U23K5a; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9B6EA1E259; Thu, 21 Nov 2024 14:40:35 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8532E1E1CC for ; Thu, 21 Nov 2024 14:40:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 29F1B3857365 for ; Thu, 21 Nov 2024 19:40:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 29F1B3857365 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=f3U23K5a Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 0EA0B3857823 for ; Thu, 21 Nov 2024 19:39:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0EA0B3857823 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0EA0B3857823 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732217998; cv=none; b=MLvgNWVnwjR6DRCs9DzoCAO3HdnXp4IoI16EUYcSC6Hd5S+UFyqsrPW6bho0L4o36AOpxHhwWALaM+BfA3MtUk6WukbmkqXk6Httd1bTlzeuganyh0WRo+E4287yavPQ1mvljvrGzjoijnNZo4EowW41BvaBUvmQUKp/j9MYA+E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732217998; c=relaxed/simple; bh=97Q9VKOaWTmsOZ4W4+y0YOgbJNxTYpEAqm+K0cQktA4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QwbAf8IFPUHOjUohWWIYlLrBZQnz8XsA5zkx9sRyCkN9EMq7I/GKvKwBri6XS7fd0qF48fNL7IaUZkASe/ZJItsWnmCY476rA9e3Qv0xEwZI0W9OjSJbwxoAxmFy0o9mNKiSSE7E0Az4CcgIdb3DMT1JwKcm+tU1SaPSv7NtM+Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0EA0B3857823 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732217997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7iU93HpSy7SiTk8J9hi/LYn/u66tL6VSXB3GZ65+4mw=; b=f3U23K5ajJHHNaj4H8dMePsFyD0z+sx+rddRY9U9Rz0nvkJQ/ABBXHjRXoWEhig30uEplK OF7+r81JSRlEZ8v4sFzG7H3neYN85iMYz8gYbddpdb6JkX4rrnO9iOKbHPLC3hFx1aNLYz 1ZHdBhMerxdE6zc3sDZR7eOJCija1go= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-RENuffSgM5Oh5k2X6LZDqQ-1; Thu, 21 Nov 2024 14:39:56 -0500 X-MC-Unique: RENuffSgM5Oh5k2X6LZDqQ-1 X-Mimecast-MFC-AGG-ID: RENuffSgM5Oh5k2X6LZDqQ Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38249bf9e82so595779f8f.2 for ; Thu, 21 Nov 2024 11:39:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732217995; x=1732822795; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7iU93HpSy7SiTk8J9hi/LYn/u66tL6VSXB3GZ65+4mw=; b=VeqNOr6PWwvmaPBQxVZYhugfzWEEJ+Eb4++QiLvLcPz3sI5f28DHmwVGBmJxtcjlax KO4RvfG1gcLYfMS5iUt9lJdB6PY5oV/EFcXcY/tgVpjASr5qNaVtJJweLv3Mzj19wZlR nzCl6eLqrFjvXMdNS0OZM72SEHys7jcxeStgYZ2+mks0Gk7w/ikEoVXu5wYH97al4432 0N3UH6Gc137utudLhy0QBX4WbqjFLHiWo0VLS0xQYEWjrN7L8CVyBFgELiFII2w970KP tbKC/Gro/8dybSmCkCE1+NlvsuFBWKR+M9UNErZBKc5dJGSiiyOnn721s9EU4R1YpvgW WSUQ== X-Gm-Message-State: AOJu0YwRWCZwVZBNwv7iBHMZ7DW12yPGWhWFnyEAKcUoAljUm2VuPD7D 5svPuD4tSBXMsdftRqcQZoD1cElfqtAO3eddZqelAZX1hpOq70A8BQRYs0EcktqznWSnGWJyXvB sdjghOchK2IF1Q7LnMrTMrVuGcs7jjBgGXpcEoD9Z9B9qHhScMtXWLxCZcBg= X-Gm-Gg: ASbGncux91IaqHZL/LHiMi5rVraEFn3zqLa/Bj3HqG2MrnZVzCRckAnLzWo9z2BUF5a 5EoMH6kkj4bPYCqkNGEdyfY2wQ7oY3JDa9lRa6TRwVJ2rwnOnFUMwOydtR6fPue+lHeTMnz9GbI 6U8n+nVQ8N0Vn5KwIBp4g+r4dl/4dXpTcix1Z+pdtehQC9gIlO4+n3UhYf/rB+ZHQMNX3QU1TSD 4HtoUOLcUCXNUqXKqjSZrDiOl5p6ZPgP3wonZSnrCOyqL52nuadSeHftYQpoa/XWYThm3CGLTgK 6g== X-Received: by 2002:a5d:5f8c:0:b0:382:47d0:64b1 with SMTP id ffacd0b85a97d-38260b4f71fmr283430f8f.2.1732217995365; Thu, 21 Nov 2024 11:39:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHxFpoQKz89wd3TYQpYsScr20Dil7qialx1QR/v1SdsUl9e4/JkOFQmF1Cws/H0o4hTqNv2jQ== X-Received: by 2002:a5d:5f8c:0:b0:382:47d0:64b1 with SMTP id ffacd0b85a97d-38260b4f71fmr283417f8f.2.1732217995014; Thu, 21 Nov 2024 11:39:55 -0800 (PST) Received: from localhost (197.209.200.146.dyn.plus.net. [146.200.209.197]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432f642f15esm92805415e9.0.2024.11.21.11.39.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2024 11:39:54 -0800 (PST) From: Andrew Burgess To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2] gdb/build-id: protect against weirdly short build-ids In-Reply-To: <20241121090508.554328c8@f40-zbm-amd> References: <20241121090508.554328c8@f40-zbm-amd> Date: Thu, 21 Nov 2024 19:39:53 +0000 Message-ID: <87jzcwml4m.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tAOWC0QhtbDBkZf6wPwWCxg__3K6dDaDKVwLV4XYuTA_1732217995 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Kevin Buettner writes: > On Thu, 21 Nov 2024 14:29:05 +0000 > Andrew Burgess wrote: > >> In v2: >> >> - Print a debug message when a short build-id is ignored. I did >> consider a warning, but I wasn't sure if that was suitable or not. >> In the end some debug output means we can at least diagnose why >> the debug lookup failed. > > I think this is fine. I've worked on bugs in the past where GDB was > spamming the user with hundreds (or thousands...) of warnings. If > we were to output a warning for this case, I think it'd be important > to make sure that it doesn't happen more than a few times per session. > In any case, I'm happy to see that you've provided a way to diagnose > the problem. > > Approved-by: Kevin Buettner Pushed. Thanks, Andrew