From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UKaPA/4seWjL0AkAWB0awg (envelope-from ) for ; Thu, 17 Jul 2025 13:03:58 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dAOz6yoN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E29ED1E11C; Thu, 17 Jul 2025 13:03:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 854511E089 for ; Thu, 17 Jul 2025 13:03:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 485FC385EC26 for ; Thu, 17 Jul 2025 17:03:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 485FC385EC26 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dAOz6yoN Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 8B589385E443 for ; Thu, 17 Jul 2025 17:02:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B589385E443 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B589385E443 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752771755; cv=none; b=juHFwRYmDYAjW1G4aULrZAq1Eif7ZUySurbEXMnjN/oJfhQOwgfqiZgwpV8xkfhifbAddPhLnN2tbScjlGt+mbI/Am9KGp7+aK+LQRAFYavcc0GlpxudaTIZQD/7+nypTsxVALtYvhyogZWwnNmqoYOBvlhXeeuak65J9dN0Y+A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752771755; c=relaxed/simple; bh=m1Zldom/zBh8NvzSXTfkCmugMmBPIBHASmE7Trn02LA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pG8ANQHlF5M0HRJ/2p3CgE6qW5UWZPrxf5PYQWGcpufwLseR0BZPlKhv8tKbDUaRleO6VkXJnjc3TzZZyMa5QGRiBoERToUrwWx9l/KcYT5o5LIeuQ3FwnLNPw5vBkVy9QKA9YSE49N5DoQKN34lY+udnVZ+Rc9vzybaREfyPmc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B589385E443 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752771755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ePltJVxyqJ/gSec7GZnvj15q/b4QqEEKFW9Rvja6y9I=; b=dAOz6yoN14o0GU6TTGKEGhLQXjKjZPgapzFH0Qv3Z3WBpLeEfMoxVmy1KPYlmtb1gr37GY IQfiOl0nY15GZJKw3Q5UlxHrTlozZbdL8lTDop3ADFr4OtBexi4O6B4h6k78w7tb0Aoqla XOGAjNW+dgqmA5/pC4X5hfV3dD2dNnA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-KdwG0eLWOvqnXapGSCdBFw-1; Thu, 17 Jul 2025 13:02:28 -0400 X-MC-Unique: KdwG0eLWOvqnXapGSCdBFw-1 X-Mimecast-MFC-AGG-ID: KdwG0eLWOvqnXapGSCdBFw_1752771746 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-454dee17a91so9879445e9.3 for ; Thu, 17 Jul 2025 10:02:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752771746; x=1753376546; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ePltJVxyqJ/gSec7GZnvj15q/b4QqEEKFW9Rvja6y9I=; b=NIf9nveoHz5pPvS7lfww/LIbwwtiLg/i6stHvSDe7guXdtKnwneweVCuk5eZFwRGBd zmwxQ6tdBdkagCSQsCJ+g/l6J29M3rFy/ByHbTcA5z04id5E/etGSEeiPUOJfeS3X0Ij pqervWo/q0sWHjemd5GXG6tpEWMlyNbriPxBJAIOTLc2BbCBtq7EN0FbJYBHS3zfeHMk KzjtT4T3zLGFYpVZk/vLACTp0d+LGIyR0pGu8DKlw53I7UW6mxwk76tAGLUUNJ9nLW9B M5/zPkQGDlIHixpIGlHLIcks8Z+EMV+xoaT5UeJ/mmNLb8JSkR2ItfJsmZbUN/sVwTJE 4B4Q== X-Gm-Message-State: AOJu0YwnQfKMJmS4Vrto2pnNZ1h5bsciisACAaYzguUK6+Oe7/ljsHA/ art/TCMoDzXDwCfLeVryaATYDzQPdpT+e/Ud6Q+9b4+MmfbQlW45GFyj15nJDIB1ndf3EmCIlFc Ba9hZeSIqz7++KDUEa1cA1+5+qh7O6FCXtp1fZ/y4YnaWJQZ3HPAdrLfxgQkFjQA= X-Gm-Gg: ASbGncu6O3XR0f5dwWi/X/kOUuZFohOoJz4pdEgsXKdf/7OzLrMnrUwvxtihZJf3fCa K1M86mdAYw3DnWoo+MhPz9IcL6u1olX+kZkwtcBM2uc07UPH1jjyY0QhWY6SmMB+aFEqTGPBx5T oxjPFVU4TLUdWJuuocQ9hNGDrFOUBs+pDz8dciq1iZrKPgEh3oqktLtVxXsdIB+lDcR8L/zA+nA yhKUPEYjdK68B9K/GQeMzhdrSUIM9Uy9K7MARe/NanvZoyDEFlzc7NfIFMykC64lAnS+kOZFNka Gjqs4By41jgxmjDzv9rfyhs5d2DW3K+jHR23kCZUPHR1et2nNmWFDy7IE8qkvNi8 X-Received: by 2002:a05:600c:4f85:b0:44a:b478:1387 with SMTP id 5b1f17b1804b1-4562e39b996mr89298675e9.17.1752771745973; Thu, 17 Jul 2025 10:02:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETGWo7J3Qe7Xlgg9cl/SYCwtlx8kFl3KLgoavyp4R56lcdYZqGqyEQtceRIHmzzDe765S88Q== X-Received: by 2002:a05:600c:4f85:b0:44a:b478:1387 with SMTP id 5b1f17b1804b1-4562e39b996mr89296335e9.17.1752771744382; Thu, 17 Jul 2025 10:02:24 -0700 (PDT) Received: from localhost (75.226.159.143.dyn.plus.net. [143.159.226.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45634f76372sm27399275e9.20.2025.07.17.10.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jul 2025 10:02:23 -0700 (PDT) From: Andrew Burgess To: "Gerlicher, Klaus" , Kevin Buettner , Tom Tromey , Pedro Alves Cc: "gdb-patches@sourceware.org" Subject: RE: [PATCH 1/1] gdb, breakpoint: use breakpoint_debug_printf In-Reply-To: References: <20250708132123.561491-1-klaus.gerlicher@intel.com> <87zfddcgr9.fsf@tromey.com> <20250709195857.5f77b521@f41-zbm-amd> Date: Thu, 17 Jul 2025 18:02:22 +0100 Message-ID: <87jz46lpi9.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ITwaUb-zjp2_isQdaGIk0Zg7cpq_vzi4mg_YTlwYhss_1752771746 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org "Gerlicher, Klaus" writes: > Hi, > > Thanks for the quick response. I see, we need to include Pedro then I guess. It's > not terribly important, I was just adding some things to breakpoint for our purposes > and I hit this oddity. For what it's worth I agree with Tom and Simon that these should not be changed to breakpoint debug. In my head the debug printing has always been based on functionality rather than file, and these do seem to be more about inferior control than breakpoint creation/management. Thanks, Andrew > > +Pedro > > Thanks > Klaus > >> -----Original Message----- >> From: Kevin Buettner >> Sent: Thursday, July 10, 2025 4:59 AM >> To: Tom Tromey >> Cc: gdb-patches@sourceware.org; Gerlicher, Klaus >> >> Subject: Re: [PATCH 1/1] gdb, breakpoint: use breakpoint_debug_printf >> >> On Wed, 09 Jul 2025 13:21:14 -0600 >> Tom Tromey wrote: >> >> > >>>>> "Klaus" == Klaus Gerlicher writes: >> > >> > Klaus> Some debug prints in breakpoint.c are using >> > Klaus> infrun_debug_printf (). This does not seem to be the >> > Klaus> right debug print macro. >> > >> > Klaus> Use breakpoint_debug_printf () exclusively in this file. >> > >> > I am not so sure about this. It seems to me that some of these may >> > mostly of interest when infrun debugging is enabled. For example: >> > >> > Klaus> - infrun_debug_printf ("incorrect thread or task, not >> > Klaus> stopping"); >> > Klaus> + breakpoint_debug_printf ("incorrect thread or task, not >> > Klaus> stopping"); >> > >> > This kind of thing is a decision impacting infrun decisions. >> >> Hmm, good point. I rescind my approval. >> >> Kevin > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928