From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zAJuCYr1cGmJVQ4AWB0awg (envelope-from ) for ; Wed, 21 Jan 2026 10:49:30 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=UDY/8RtM; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1BE3E1E0AD; Wed, 21 Jan 2026 10:49:30 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AD0331E08D for ; Wed, 21 Jan 2026 10:49:29 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 29D014BC8985 for ; Wed, 21 Jan 2026 15:49:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 29D014BC8985 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=UDY/8RtM Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 783834BC896D for ; Wed, 21 Jan 2026 15:48:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 783834BC896D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 783834BC896D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769010515; cv=none; b=QOutc25tXTKQlZB2uQgcXM6qmCDEnpW9NYiJ7KcMF3Z8EFNcsKk3uXuoaYXO6LeajNwG37/D79aWHK0uWvKh1H0yjXuElpS6/BUWnwyJ8NpzWie3VKp8GIbJFFqK4Lew3CMzCRAs0P/ijBC6cdbnK7axU/fePjAp7so4gPZjH4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769010515; c=relaxed/simple; bh=PU0Acp5tSB3oJf8RHKEuPBBpH1nwxdiwzCgpmkkEKSs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eJJmErsdlt06TjnCXOryqGd+lFsKJbkrx5yMoOVV12aGeQUcWEr1b0hmunESks7WPTi0fRRMCU/+qs2luIAJk2wUbdpvWLw9E88AB0TPmbYV08Bgs1W9nb8b3Y8ugkGf2ES9xNOKRumaSAWThFIwRqXfVncPc0MMCgvl7juSoEQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 783834BC896D Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id iYkdvKn22KjfoiaRevjif3; Wed, 21 Jan 2026 15:48:34 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id iaRdvoEDO2l0kiaRev7Jro; Wed, 21 Jan 2026 15:48:34 +0000 X-Authority-Analysis: v=2.4 cv=UfRRSLSN c=1 sm=1 tr=0 ts=6970f552 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=aBat6alEuegmzk28F-YA:9 a=Do_0w_a-DlIA:10 a=ETxJbj5dEL5NKU_Z2VZu:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PU0Acp5tSB3oJf8RHKEuPBBpH1nwxdiwzCgpmkkEKSs=; b=UDY/8RtMrozL90Y/N/SDppn8/r N12TZKBQJF/BYu9R0ED9JUumgDyI9HX5K5DzvpwXE4+WRToxBxOKuOvFwrQgBMtui6GW5UEYGfFnC 3ptqxWNaipRmsOQcpfi859GuT; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:55794 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1viaRd-000000001x1-1lWx; Wed, 21 Jan 2026 08:48:33 -0700 From: Tom Tromey To: Hannes Domani Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 09/11] Move auto_wide_charset gdbarch method to windows-tdep In-Reply-To: <20260117135448.2666604-9-ssbssa@yahoo.de> (Hannes Domani's message of "Sat, 17 Jan 2026 14:54:32 +0100") References: <20260117134052.2660009-1-ssbssa@yahoo.de> <20260117135448.2666604-9-ssbssa@yahoo.de> X-Attribution: Tom Date: Wed, 21 Jan 2026 08:48:32 -0700 Message-ID: <87jyxb7yr3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1viaRd-000000001x1-1lWx X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net (bapiya) [97.122.114.32]:55794 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKSQGRO6V69gt+WhmFbUsyVfQmW6+fwzgwbFtVknPpyUPHh/tl+gKga7Fk34xvScK3Bd1J8r1KaTDwdBtSY08YcC5MCWNr+e5Um/aExk7BFcPKgYt/h0 j/1KQovr9lTPTEPPrglizvdGGmV7UvUTVEbZ380dhejS+CbXeawc2G23ETTLo6/4nKMvFbdCkGk2bh8rFyxYUtaF+hn69vgd+AA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Hannes" == Hannes Domani writes: Hannes> It's the same for all Windows ABIs. Thank you. Hannes> +static const char * Hannes> +windows_auto_wide_charset (void) Please remove the 'void' from this line. Ok with this change. Approved-By: Tom Tromey Tom