From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EUrTCROnoWmrlgwAWB0awg (envelope-from ) for ; Fri, 27 Feb 2026 09:15:47 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=PM1Jeq0s; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 225181E0DD; Fri, 27 Feb 2026 09:15:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7EA7B1E089 for ; Fri, 27 Feb 2026 09:15:46 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 26B8C4BA2E1D for ; Fri, 27 Feb 2026 14:15:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26B8C4BA2E1D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=PM1Jeq0s Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 9D1B14BA23E6 for ; Fri, 27 Feb 2026 14:15:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D1B14BA23E6 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9D1B14BA23E6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772201719; cv=none; b=vhyYznoApFqL62NZJo7OzpYKxCW0ny95EEPX443bVLJCqnDvKjP22Get6++qla1T+foVhvIbHoDg882B6Pz9gTwp552S5YYThbztlHK64oN8qUQwMXdlOzUYf49HNcANMW/kaYy+Yim6pP986WaE3cG3gyJCJ+uo9FkLxHUIA+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772201719; c=relaxed/simple; bh=27SOn1tX7D/iS8WP7uxDStPzYZ75yDRc0xWcawYALpg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wntJKprBT2XNupjolK/g5kUWwdGj9DO0MjlrRHWV2LmZJXq2MAY874kRyy0KT8sc5fYgh+YxPqqkPCqqflqA2++gxf9A0ySxj6Z7uESmvgq4xGHn2Qv4/sqHvqp0Uh6jZjYQS5O9hFCnlE7k9U3PGduIqfIlvar4NXbpZJSqu64= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D1B14BA23E6 Received: by mail-ot1-x331.google.com with SMTP id 46e09a7af769-7d18d0e6d71so1620658a34.1 for ; Fri, 27 Feb 2026 06:15:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1772201719; x=1772806519; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=bJgE13Ou0izlpxdrm0Y9iUviA3jObQum5JtOslaFj3s=; b=PM1Jeq0slyHHQaeilwDnSg8JF6wOtQz7qKsVFAWtiaOWN5Ctd/d3KLJNI8nT2CTMck eu1uoX14dSbI7RuWOArv2j6G+0xEXjm6ZDiA45avGY+FLWN6fooJyvqCPf5pl678+Nrs SroikKCrVq5VscUaJBFNZPtMaKnfVuSBQkFn8qBO5NxKWJY9JpGQeP4xnm3zEoWEWn19 aEbpUce6gV1rATodUuHoiCM6WuyOl/gT0Jh0WNfAjRj5mdfGfyQ+cFK9El8xz794X2bh 1cknBzF9HGugyez8UU47KvRaK58DRBTUaIAKknpQXRMo6OjNJcKn9267VsP9+OmLNCor En8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772201719; x=1772806519; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bJgE13Ou0izlpxdrm0Y9iUviA3jObQum5JtOslaFj3s=; b=gPFjoQUUp3HuaS8WdMoIjX8IE3DWm1WWMucQkMTXywTkCKBW/OI3LCUDoS7M+r3CcO aYwYShf+zNTPwS6aCCVNiiVPv/lgJF+t/FmkpG9FxiM7xL5wdPMo3tegfIH7oXuF2Yth ZqZXCS4YdXTnwt4JHlkoazF6OC4biE0gYQkAlUGrCtUeP1Vvwpz5IkSM06kEdfBFTT1W ACIaaCNOqR2b/5cjh5MCRZvXQQHbDfiC5rbl57STXM9i44CePZgIvInrZHPsCMo66XFm sSVaOLUxkMFabsfFVbhgSW5l1WSiQp4yRlUeOqoWjfONffrJA9yz2tiEq98Mcpi/p9Te KhRg== X-Forwarded-Encrypted: i=1; AJvYcCX8J2jFAhysTTDf4Y5RfC+ldDXjKYEMEoJSAWOnW62SAI8WP396lHx33ddUrYCsRgYFy/nbfmUwtg5Rnw==@sourceware.org X-Gm-Message-State: AOJu0YwTd1JIHGgZQML6MiEGgt2zJY/zwh7vGmKxzxp929rKCXM9AORg SxbFRgY0CRfyTKPFozKL3vDIkttcWV5Mig+R3BKJbPTQUYLZE1qM/ex1di2FlEFLZA== X-Gm-Gg: ATEYQzx1TSPZvlpj8Ezv4NrH3tce1nm+nI6Z/y2Pt7m2Yyz4W5UzTT1IEV9hpBRnG9D x+RGoeOuNwVprG8DvUhM1AN69h4LPfjq1sFu5cg8qF149hw6abVS8eqpuXzoOWcjqtLAP6oZEiH lBGjBa2xAZ2pz8vEm4kRTIVpdcVtzh+r3LptfmAak6b3/BtP54JQMLWvEzi4vp92odrrT324L++ VuFvaQ8LjwRp8IFIN/LsmxdVpA5+H8WlMQOjxPKFAMUe7nbWKbuX1aqPto+PQnJOCZUJ1GFpZ7n HtZ81DOd5oeBgEamnpYQuAf4XnGOlRuJqhn6YMhmPAlLYdQn9MF+BLgQKch3uGV1OxbAky2efGX ORHjDER1k5YbQTrpV+WzjKeuaobvR5y0o0r3/tbGH1bQ+azaUMfliCQLk99U+4dNA4zNDjhVsUd yohpmW4lBZnjd92ir9/8sl6gL9oF//C5hXJsZlOotx+tmlqw== X-Received: by 2002:a05:6830:83bc:b0:7cf:d18e:706e with SMTP id 46e09a7af769-7d591b237bemr2010450a34.5.1772201718981; Fri, 27 Feb 2026 06:15:18 -0800 (PST) Received: from bapiya (97-122-122-234.hlrn.qwest.net. [97.122.122.234]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d58647b17esm4337233a34.8.2026.02.27.06.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 06:15:18 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Use enum types for remote fileio flags In-Reply-To: (Simon Marchi's message of "Thu, 26 Feb 2026 12:10:58 -0500") References: <20260225-target-fd-newtype-v1-0-e04af6692ccb@adacore.com> <20260225-target-fd-newtype-v1-2-e04af6692ccb@adacore.com> X-Attribution: Tom Date: Fri, 27 Feb 2026 07:15:17 -0700 Message-ID: <87jyvyuvbe.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> + proc->stat.tag_fd = target_fileio_open (NULL, cl_name, >> + FILEIO_O_RDWR | FILEIO_O_EXCL, >> + FILEIO_S_IRWXU, 0, &target_errno); Simon> Perhaps change that 0 to false (the `bool warn_if_slow` param). I added a patch to fix up the warn_if_slow stuff. Simon> So the flags here goes from "false" (obviously wrong) to FILEIO_S_IRWXU. Simon> Since we don't pass the _CREATE flag, I think that the value for mode Simon> is irrelevant. If so, it might be clearer to pass 0, otherwise it makes Simon> it seem like the value we pass is meaningful, which can be confusing. I fixed this. Simon> But I also noticed the enum type is not actually used. It could be used Simon> in remote_fileio_seek_flag_to_host, although it wouldn't be terribly Simon> useful. So perhaps this enum could be anonymous actually. Yeah I did this, thanks. >> >> /* errno values */ >> enum fileio_error >> @@ -146,12 +159,12 @@ extern int fileio_error_to_host (fileio_error errnum); >> /* Convert File-I/O open flags FFLAGS to host format, storing >> the result in *FLAGS. Return 0 on success, -1 on error. */ >> >> -extern int fileio_to_host_openflags (int fflags, int *flags); >> +extern int fileio_to_host_openflags (fileio_open_flags fflags, int *flags); Simon> In the implementation, the second parameter is named open_flags_p. You Simon> could maybe rename it here. That would free up "flags" for the first Simon> parameter, if you want. I made them use the same names. I didn't change it to 'flags' though. Tom