From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mW79BfyIqGk+bBQAWB0awg (envelope-from ) for ; Wed, 04 Mar 2026 14:33:16 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VqpcN8xD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 11A9E1E0DD; Wed, 04 Mar 2026 14:33:16 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 775F41E089 for ; Wed, 04 Mar 2026 14:33:15 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B57254BA23CA for ; Wed, 4 Mar 2026 19:33:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B57254BA23CA Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VqpcN8xD Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 4E6F94BA2E0D for ; Wed, 4 Mar 2026 19:32:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4E6F94BA2E0D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4E6F94BA2E0D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772652767; cv=none; b=YPKCEC2dSF6xyLbf/LMiyJFKKjbwbgbzDiPc4v1NQs5PupvByTuQl2vKIN6ss1znu45Rc4mHsIPpS+6ZcsB0dFbhSK7rOA3I8ShOUyjyqxR9UuIaUf+EBadc0tRSYlpqx1sS8wWvrFWFJyPpE6wWKByddNoXaZYoCdSKBoB0+Zo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772652767; c=relaxed/simple; bh=qhZGAvImpuG+rHBtmB8AyCQJKsnVkBD376ljwgHdIa0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sEMESd9MmR7zusd47tyarjbvaOhmiOdwBpxxr8p9iTldL5mvui8D9z9GQWhb9uuNUu9j6GLebQJ0AtO0Vvi6gtXeT3Z8PCUDkDfyKcY88aAhIDY3qrvX1T+ILJ5ML3SDUcDxS2z6B6qRFVL0HGTw5vC90VjQCbYyaRZZ/WJWe8o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4E6F94BA2E0D Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id xiL4vCLKOaPqLxrxevrYWO; Wed, 04 Mar 2026 19:32:46 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xrxZvOjsGSqlVxrxZvZ0HR; Wed, 04 Mar 2026 19:32:41 +0000 X-Authority-Analysis: v=2.4 cv=I7FlRMgg c=1 sm=1 tr=0 ts=69a888de a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=p92IUI1YZaonTwgz_wQA:9 a=ZXulRonScM0A:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yvQmcrZKLsiatYuJ5mO++QlgLT9s7YfYjLnae7mfiAc=; b=VqpcN8xDEUBKAZYPQX/qP1ck/a C1dKx+0tV/WbFMMcKpSfT50VlqLJ77tD1x9OF7VUMsRZTBVbagWnxK72KpAefhChlGuDVqE+ukN0l 7YFEpJ9FWcvUraH5OY5NbWXUn; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:51450 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vxrxZ-000000029q9-0Crw; Wed, 04 Mar 2026 12:32:41 -0700 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH v3 7/9] gdb: make expanded_symbols_functions hold compunit symtabs In-Reply-To: <87seafo0xu.fsf@tromey.com> (Tom Tromey's message of "Wed, 04 Mar 2026 12:21:33 -0700") References: <20260217195329.3833518-1-simon.marchi@polymtl.ca> <20260228035425.422765-1-simon.marchi@efficios.com> <20260228035425.422765-8-simon.marchi@efficios.com> <87seafo0xu.fsf@tromey.com> X-Attribution: Tom Date: Wed, 04 Mar 2026 12:32:39 -0700 Message-ID: <87jyvro0fc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1vxrxZ-000000029q9-0Crw X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:51450 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKq9GXjQDx2c5Kvrx5auSuS2C1ijVbMqwWcwGvDtf0brqqgbNcAfUIDsUNf+SBqTTUmYxFfEGDGu9kC6H8CvBtiuzSjOMOp/XXv7ppcFO68cRvIhKw3G TY0zDYFFaxbd5+7ZHUTwiU98wzgnIm59dfPJaRG47jpel2sxCbW7KEWAX8AzFcTiLrsFaOlnLrTXGNg/YrQN/hWIY3fJ/fSxir0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon> Change the expanded_symbols_functions quick functions type to hold and Simon> use a list of compunit symtab to search. Simon> Right now the sole user of expanded_symbols_functions is JIT. Update it Simon> to keep a vector of compunits as they are finalized, and pass this Simon> vector to the expanded_symbols_functions object. Tom> I think this is a good direction but this patch isn't quite complete. Tom> The issue is that there are still a handful of spots in gdb that loop Tom> over all compunits. But with this change, these spots will skip some Tom> compunits. It took me a while but I finally realized that the new vector is in addition to the objfile's compunits. This seems kind of ugly to me but OTOH it doesn't have the problems I ascribed to it. Tom